Date: Thu, 30 Sep 2021 07:33:26 -0600 From: Warner Losh <imp@bsdimp.com> To: Emmanuel Vadot <manu@bidouilliste.com> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: 79a100e28e3c - main - bluetooth: complete removal of ng_h4 Message-ID: <CANCZdfobJTDXGXphRGf1rf5akKR1FTcLLOWe2AfR6ERnVUfP_Q@mail.gmail.com> In-Reply-To: <20210930111120.e038ca0a2a3c770f4778fa84@bidouilliste.com> References: <202109300200.18U20EZD084710@gitrepo.freebsd.org> <20210930111120.e038ca0a2a3c770f4778fa84@bidouilliste.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Sep 30, 2021 at 3:11 AM Emmanuel Vadot <manu@bidouilliste.com> wrote: > On Thu, 30 Sep 2021 02:00:14 GMT > Warner Losh <imp@FreeBSD.org> wrote: > > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=79a100e28e3c814773bb4c1826cfa25fbe31140e > > > > commit 79a100e28e3c814773bb4c1826cfa25fbe31140e > > Author: Warner Losh <imp@FreeBSD.org> > > AuthorDate: 2021-09-05 18:41:16 +0000 > > Commit: Warner Losh <imp@FreeBSD.org> > > CommitDate: 2021-09-30 02:00:02 +0000 > > > > bluetooth: complete removal of ng_h4 > > > > The ng_h4 module was disconnected 13 years ago when the tty later was > > locked by Ed. It completely fails to compile, and has a number of > false > > positives for Giant use. Remove it for lack of interest. Bluetooth > has > > largely (completely?) moved on from bluetooth over UART transport. > > > > OK'd by: emax > > Sponsored by: Netflix > > Differential Revision: https://reviews.freebsd.org/D31846 > > Every BT+WIFI combo chip used in SBC uses uart for bluetooth. > I have no idea if it uses this or need something else as I've never > looked. > But anyway, if it fails to compile now I'm fine with removing it, if > someone wants to add support for bluetooth to SBC they could always > revive this code. > Yes. If there's a need, we can revive the code... once it's fixed... It looked to take a bit more time than I had.... I've had others make the same or similar correction... Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfobJTDXGXphRGf1rf5akKR1FTcLLOWe2AfR6ERnVUfP_Q>