Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 28 Feb 2002 10:58:02 -0800 (PST)
From:      Julian Elischer <julian@elischer.org>
To:        Josef Karthauser <joe@tao.org.uk>
Cc:        Julian Elischer <julian@FreeBSD.org>, peter@freebsd.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/dev/usb ohci.c
Message-ID:  <Pine.BSF.4.21.0202281056200.6492-100000@InterJet.elischer.org>
In-Reply-To: <20020228184733.GB15224@genius.tao.org.uk>

next in thread | previous in thread | raw e-mail | index | archive | help


On Thu, 28 Feb 2002, Josef Karthauser wrote:

> On Thu, Feb 28, 2002 at 06:36:40PM +0000, Josef Karthauser wrote:
> > On Wed, Feb 27, 2002 at 11:24:55AM -0800, Julian Elischer wrote:
> > > julian      2002/02/27 11:24:55 PST
> > > 
> > >   Modified files:
> > >     sys/dev/usb          ohci.c 
> > >   Log:
> > >   Add a comment explaining a code change..
> > 
> > Please don't commit to the usb subsystem without feeding patches
> > through me or I will give up and leave the merge from NetBSD to
> > someone else.
> 
> <snotty mode off>

OK but we needed to get the kernel compiling again.
The comments were because it wasn't obvious why the change was made
and I could see that it would be reverted at the first oportunity without
it..

Any movement on the fact that the usb code allocates 2K+ on the stack?



> 
> I'm not putting a lock on this, but if you take a look at where we
> are you'll find that we're currently about a year behind in commits
> for the controller code. If we want USB2, etc, we need to refrain
> from developing the usb subsystem until we're relatively in sync
> with NetBSD - at which point we can easily hand them patches, and
> we can all (*BSD) move forward together.
> 
> I realise that earlier in the week there were some warnings in ohci
> that stopped play and I don't mind patches that fix problems like
> that, but if you want to work on this code you also have to take
> responsibility for keeping it in sync with the other BSDs.  The USB
> code is wierd in that it's not really contrib/ material because
> it's being developed in all the BSDs at the same time.  FreeBSD,
> however, is in a funny state because for some reason (probably lack
> of someone's time) we're way behind the status quo, and we've
> diverged slightly during that time because of global SMPng/KSE/etc
> changes.
> 
> My goal is to get us up to speed.  I beg you to not make my life
> harder than it already is.  I assure you that I am working on this
> stuff. (Three hours of hand patching code today already).
> 
> Thanks,
> Joe
> 


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0202281056200.6492-100000>