Date: Fri, 7 Mar 2008 09:34:06 -0800 From: "Maksim Yevmenkin" <maksim.yevmenkin@gmail.com> To: "Brooks Davis" <brooks@freebsd.org> Cc: freebsd-rc@freebsd.org, freebsd-bugs@freebsd.org, usselmann.m@icg-online.de Subject: Re: conf/121452: /etc/rc.d/ppp not working as expected Message-ID: <bb4a86c70803070934r2d736cebp1f3ece888c9ea14a@mail.gmail.com> In-Reply-To: <20080307154951.GB34313@lor.one-eyed-alien.net> References: <200803071133.m27BXoXH096841@freefall.freebsd.org> <20080307154951.GB34313@lor.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Mar 7, 2008 at 7:49 AM, Brooks Davis <brooks@freebsd.org> wrote: > The following patch should allow profile name to contain ".-/+" characters > as we do with interfaces. It also documents the previous undocumnted > per-profile overrides of _mode and _nat which were the cause of the problem. > If someone who uses ppp could test this, I'd be happy to commit it. i'm not so sure about this one. if i have "t-dsl" as a profile name, i will not be able to specify any overrides for this profile, because shell won't let me have "ppp_t-dsl_mode" and/or "ppp_t-dsl_nat" variable. so, the translation here is not really needed, imo, and, perhaps, could even be considered harmful. perhaps we should do one of the following 1) demand that ppp profile names should be "shell clean" and document it or 2) if a ppp profile name is not "shell clean" simply do not evaluate profile overrides and use defaults thanks, max
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bb4a86c70803070934r2d736cebp1f3ece888c9ea14a>