Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 28 Feb 2008 10:33:19 +0200
From:      Andriy Gapon <avg@icyb.net.ua>
To:        pav@FreeBSD.org
Cc:        Bruce Evans <bde@zeta.org.au>, freebsd-hackers@FreeBSD.org, scottl@FreeBSD.org, freebsd-fs@FreeBSD.org, Julian Elischer <julian@elischer.org>, Remko Lodder <remko@FreeBSD.org>
Subject:   Re: fs/udf: vm pages "overlap" while reading  large dir [patch]
Message-ID:  <47C671CF.9020101@icyb.net.ua>
In-Reply-To: <1204053786.1799.0.camel@ikaros.oook.cz>
References:  <200612221824.kBMIOhfM049471@freefall.freebsd.org>	 <47A2EDB0.8000801@icyb.net.ua> <47A2F404.7010208@icyb.net.ua>	 <47A735A4.3060506@icyb.net.ua> <47A75B47.2040604@elischer.org>	 <1202155663.62432.0.camel@ikaros.oook.cz> <47A8754C.5010607@icyb.net.ua>	 <1202235368.68281.12.camel@ikaros.oook.cz> <1204053786.1799.0.camel@ikaros.oook.cz>

next in thread | previous in thread | raw e-mail | index | archive | help
on 26/02/2008 21:23 Pav Lucistnik said the following:
> Pav Lucistnik píše v út 05. 02. 2008 v 19:16 +0100:
>> Andriy Gapon píše v út 05. 02. 2008 v 16:40 +0200:
>>
>>>> Yay, and can you fix the sequential read performance while you're at it?
>>>> Kthx!
>>> this was almost trivial :-)
>>> See the attached patch, first hunk is just for consistency.
>>> The code was borrowed from cd9660, only field/variable names are adjusted.
> 
> Just tested it with my shiny new Bluray drive, and it work wonders.
> Finally seamless playback of media files off UDF carrying media.
> 
> So, how does it look WRT committing it?
> 

Pav,

thank you for the feedback/reminder.
In my personal option the latest patch posted and described at the
following like is a very good candidate for commit:
http://docs.FreeBSD.org/cgi/mid.cgi?47AA43B9.1040608
It might have a couple of style related issues, but it should improve
things a bit even if some larger VM/VFS/GEOM issues remain.

And by the way, a patch from the following PR would be a good
"side-dish" for the above patch:
http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/78987
I think it is simple and obvious enough.

-- 
Andriy Gapon



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47C671CF.9020101>