Date: Thu, 02 May 2002 16:39:16 -0600 From: Warner Losh <imp@harmony.village.org> To: Bruce Evans <bde@zeta.org.au> Cc: Dima Dorfman <dima@trit.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf kmod.mk Message-ID: <200205022239.g42MdGr04255@harmony.village.org> In-Reply-To: Your message of "Fri, 03 May 2002 03:31:49 %2B1000." <20020503032719.G4775-100000@gamplex.bde.org> References: <20020503032719.G4775-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20020503032719.G4775-100000@gamplex.bde.org> Bruce Evans writes: : > > +.if !exists(/usr/sbin/kldxref) : > > +NO_XREF=yes : > > +.endif : : This is broken. kldxref might be in $PATH but not in /usr/sbin, or vice : versa. True. However, it breaks a case I don't care about. Until make gets a exists_in_path(foo), this is a reasonable compromise. : > > .if !defined(NO_XREF) : : If a non-broken existence test ifdef exists, why not write it here directly. I didn't want to remove NO_XREF, but rather just use it. : I agree. Ignoring errors in Makefiles is a bug. Yes. It even seems to work. :-) Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200205022239.g42MdGr04255>