Date: Fri, 04 May 2018 13:43:29 -0600 From: Ian Lepore <ian@freebsd.org> To: Matt Macy <mmacy@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333261 - head/sys/conf Message-ID: <1525463009.57768.281.camel@freebsd.org> In-Reply-To: <201805041931.w44JVS3d096407@repo.freebsd.org> References: <201805041931.w44JVS3d096407@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 2018-05-04 at 19:31 +0000, Matt Macy wrote: > Author: mmacy > Date: Fri May 4 19:31:28 2018 > New Revision: 333261 > URL: https://svnweb.freebsd.org/changeset/base/333261 > > Log: > % WITHOUT_FORMAT_EXTENSIONS= XCC=/usr/local/bin/gcc8 make -j96 > buildkernel KERNCONF=GENERIC-NODEBUG -s >& log > % grep "inlining failed" log | wc > 234 3570 36065 > Consensus on those polled is that inlining failure warnings are not > useful > > Approved by: sbruno This is another marginal commit message. A good commit messages starts with a sentence or two that summarizes what's been changed, followed by some non-zero amount of extra information that says why (for all but the most trivial self-obvious changes). This is pretty good on the "why". Consider how this is going to look buried in the output of "svn log kern.mk" (or on svnweb.freebsd.org) when you're skimming through the commit history looking for what changed while you're tracking down some problem. When you run into this commit in the log, you're going to have no option but to stop what you're doing and look at the diff to see if it's germane to your search, because of the missing summary information. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1525463009.57768.281.camel>