Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 22 Feb 2008 17:00:46 GMT
From:      Sam Leffler <sam@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 135971 for review
Message-ID:  <200802221700.m1MH0keN030447@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=135971

Change 135971 by sam@sam_ebb on 2008/02/22 17:00:03

	pull check that SA is unicast to common mgt frame processing so
	all frames are checked

Affected files ...

.. //depot/projects/vap/sys/net80211/ieee80211_hostap.c#15 edit

Differences ...

==== //depot/projects/vap/sys/net80211/ieee80211_hostap.c#15 (text+ko) ====

@@ -811,6 +811,14 @@
 			vap->iv_stats.is_rx_tooshort++;
 			goto out;
 		}
+		if (IEEE80211_IS_MULTICAST(wh->i_addr2)) {
+			/* ensure return frames are unicast */
+			IEEE80211_DISCARD(vap, IEEE80211_MSG_ANY,
+			    wh, NULL, "source is multicast: %s",
+			    ether_sprintf(wh->i_addr2));
+			vap->iv_stats.is_rx_mgtdiscard++;	/* XXX stat */
+			goto out;
+		}
 #ifdef IEEE80211_DEBUG
 		if ((ieee80211_msg_debug(vap) && doprint(vap, subtype)) ||
 		    ieee80211_msg_dumppkts(vap)) {
@@ -1742,11 +1750,6 @@
 			vap->iv_stats.is_rx_mgtdiscard++;
 			return;
 		}
-		if (IEEE80211_IS_MULTICAST(wh->i_addr2)) {
-			/* frame must be directed */
-			vap->iv_stats.is_rx_mgtdiscard++;	/* XXX stat */
-			return;
-		}
 
 		/*
 		 * prreq frame format



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200802221700.m1MH0keN030447>