Date: Fri, 02 Jun 2000 23:49:02 -0700 From: Julian Elischer <julian@elischer.org> To: Archie Cobbs <archie@whistle.com> Cc: Freebsd-net@FreeBSD.ORG Subject: Re: Patch review request (ng_ether(4)) Message-ID: <3938AA5E.15FB7483@elischer.org> References: <200006030221.TAA65766@bubba.whistle.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Archie Cobbs wrote: > > Julian Elischer writes: > > > > As soon as I can access freefall again I'll put up a new patch. > > > > > > OK, try this one: > > > > > > ftp://ftp.whistle.com/pub/archie/misc/NGETHER.patch.2 > > > > you need to block attaches to orphan if the lower hook is in use, > > and visa versa. > > It should already do that.. they both use priv->lower. OK comment in ng_ether_input_orphan() is wrong. You can't use NG_SEND_DATA_RET() in an ethernet driver (on input) because you need to use NG_QUEUE_DATA() (splimp, remember) My thought is that you would supply a separate hook for 'FILTER' operations which you would warn would have to be run at splimp. The splnet and splimp graphs can only be joined by queueing links (going up). I think this needs work, and there is a possibility that we could put transfer characteristics as a property on links so that the right thing happens. The FILTER hooks would either have to be attached to nodes that use NG_QUEUE_DATA(), or which had no connection to the splnet universe. Automatic registration of spl levels on hooks might lead to some automatic handling of this but a/ I think the programmer should know what is going on. b/ this may all become moot with the removal of SPLs for interrupts. > > -Archie > > ___________________________________________________________________________ > Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com -- __--_|\ Julian Elischer / \ julian@elischer.org ( OZ ) World tour 2000 ---> X_.---._/ presently in: Perth v To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3938AA5E.15FB7483>