Date: Fri, 3 Apr 2015 11:02:45 -0600 From: Warner Losh <imp@bsdimp.com> To: Craig Rodrigues <rodrigc@FreeBSD.org> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>, FreeBSD Toolchain <freebsd-toolchain@freebsd.org> Subject: Re: Failed to build rescue with gcc 4.9 Message-ID: <2D2191D4-DB6F-4889-9CA9-DFEE495D8302@bsdimp.com> In-Reply-To: <CAG=rPVeYShPad4KXr1uzczZJ0-_vBytSRArw7wGk_8VZF1vm1A@mail.gmail.com> References: <CAG=rPVeUQ0mm8JKEWDcdw2trqOrUtDx0pGwm8FqbEzuf9P39rA@mail.gmail.com> <CAG=rPVcfUFme=9BzTHCKtV2bT8ASHX0JPcczp343mjE9=Kfoug@mail.gmail.com> <CAG=rPVeYShPad4KXr1uzczZJ0-_vBytSRArw7wGk_8VZF1vm1A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_2BDF8736-4C30-446F-AD28-5CF3A9FFAD91 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Apr 3, 2015, at 10:58 AM, Craig Rodrigues <rodrigc@FreeBSD.org> = wrote: >=20 > On Thu, Apr 2, 2015 at 8:27 AM, Craig Rodrigues <rodrigc@freebsd.org> = wrote: >=20 >>=20 >> Actually, I am building on a 10.1-RELEASE box. >>=20 >> I was able to get this successful build: >>=20 >> = https://jenkins.freebsd.org/job/FreeBSD_HEAD_external_toolchain_gcc/38/con= sole >>=20 >> by applying this patch (the ${TARGET_ARCH} !=3D ${MACHINE_ARCH} = checks >> seemed wrong to me): >>=20 >> Index: Makefile.inc1 >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- Makefile.inc1 (revision 280979) >> +++ Makefile.inc1 (working copy) >> @@ -1457,12 +1457,9 @@ >> # we get done with the earlier stages. It is the last set of tools = needed >> # to begin building the target binaries. >> # >> -.if ${TARGET_ARCH} !=3D ${MACHINE_ARCH} >> .if ${TARGET_ARCH} =3D=3D "amd64" || ${TARGET_ARCH} =3D=3D "i386" >> _btxld=3D usr.sbin/btxld >> .endif >> -.endif >> -.if ${TARGET_ARCH} !=3D ${MACHINE_ARCH} >> .if ${MK_RESCUE} !=3D "no" || defined(RELEASEDIR) >> _crunchide=3D usr.sbin/crunch/crunchide >> .endif >> @@ -1469,7 +1466,6 @@ >> .if ${TARGET_ARCH} =3D=3D "i386" && defined(RELEASEDIR) >> _kgzip=3D usr.sbin/kgzip >> .endif >> -.endif >>=20 >> # If we're given an XAS, don't build binutils. >> .if ${XAS:M/*} =3D=3D "" >>=20 >>=20 >=20 > I backed out this patch from my tree, and rebuilt everything > in my 10.1-RELEASE VM from the latest CURRENT sources. At this > point, I ran into the same problem building rescue which I reported in > = https://lists.freebsd.org/pipermail/freebsd-toolchain/2015-March/001545.ht= ml >=20 > I put the patch back in my tree, and recompiled everything, and the > problem went away. >=20 > To reliably build the tree, I think this patch should go in, so that = these > tools are properly bootstrapped during the build. That shows that something in the list is needed. Likely only crunchhide. It doesn=E2=80=99t tell us why we need it, or when we started needing = it, or what other conditions we might need it. This information is critical to = document so we know when we can stop doing it in the future. I=E2=80=99m = extremely reluctant to commit this until we know these details. Sorry for being a bit of a pain about this, but these lists are = something that I=E2=80=99ll be maintaining long into the future and we=E2=80=99ve had = issues in the past where people would just hack something in and not document, then = lovingly copy it over and over w/o understanding :( Warner --Apple-Mail=_2BDF8736-4C30-446F-AD28-5CF3A9FFAD91 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVHse1AAoJEGwc0Sh9sBEADggP/iCbB09Q7erlfSLE+9AWKGyC Q1bsWfq8H4srlKML8srlMidogSXpn5m9CBRIPKlOhOmhF9bdeJHO3uM4WYoU1WF8 I7AMl7b2x6PRicxpJJL0eSGw3AL8iuXFwRv/beCAqoe4FTh96fq633klATmwxHV2 MGt0WFhS7gQ0GyhBI2AyDUsb5k5dmSgF7HIbADcXlju/v5q0WU0EK+UkpRNAGXME EcvW+XRa9OJFkl+ZqWvZab69AzAd7xLtAagwMWBzYT2sc2fyOUQaVHW4nYGgf1Wq GOu4Yb+pYmsQiVNfqDS9eLMIQvB4MXtRXUnMAyrmtLkvp6p72sW4oI7g49GNkVGd n8/cv9jd1Qqx9hhlLUe/8vuhKh/hStyG0A6OnfFP3gr3Caoz9Jeb5NMtOZyRfnvg 3fGA7PRir/NgA8Xo0Gh6BSuDSo+ybELQQNn8YWL5iBcZ8bSFRJww6DM7anaJux+M PSLhC4FvJs65SwLUNLEpi2M2nN7w5aN3WiwV+Y+TxQaDN592om4U7X/RKfS2oltn x3P5W6EQWIVlm4woIQrYQNdMMHh6h0YciY33UwdDVXaXhmmvDiN8gu5PXa+X2gvr RwWZZHmXQcR81K26IZd/Yu2StzX8QZiuJjpsVgmR0pCHLsSnsbF6Uj9Of4p+KT+E jECHoywxjgMMIKTCl1Re =tNOu -----END PGP SIGNATURE----- --Apple-Mail=_2BDF8736-4C30-446F-AD28-5CF3A9FFAD91--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2D2191D4-DB6F-4889-9CA9-DFEE495D8302>