Date: Wed, 09 Feb 2011 00:22:01 +0300 From: "Emil Muratov" <gpm@hotplug.ru> To: "Bartosz Stec" <admin@kkip.pl>, "Kostik Belousov" <kostikbel@gmail.com> Cc: freebsd-fs@freebsd.org Subject: Re: Memory leak in ZFS? Message-ID: <op.vqlsazg6aevz08@ghost-pc.home.lan> In-Reply-To: <20110208203653.GC78089@deviant.kiev.zoral.com.ua> References: <AANLkTi=8fFwiaQ4%2Bm_cWFkXwpa4_W0_DDV2aW8vyNU4E@mail.gmail.com> <op.vqjyb21daevz08@ghost-pc.home.lan> <4D510BBB.1060708@kkip.pl> <20110208102727.GA8555@icarus.home.lan> <4D511F65.2050503@kkip.pl> <4D519F97.2000805@kkip.pl> <20110208203653.GC78089@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
>> >>Simple test: if you disable use of sendfile (but not AIO) in Samba, >> does >> >>the problem go away? >> >I've just disabled sendfile in smb.conf and I'll report in about 2 >> >days, after reboot which I will perform tonight. >> >I hope it won't hit samba performance too much ;) >> > >> We didn't need to wait 2 days :) >> Now I can confirm that sendfile under SAMBA + ZFS are responsible for >> issue. Here's sample output from my monitoring script[1] (update every 2 >> seconds): >> >> >> This behaviour has been seen while copying 600MB file from SAMBA share >> with sendfile enabled. >> It doesn't happen when writing to samba share, and it doesn't happen >> with sendfile disabled, both ways. >> For me it looks like memory which leaks should be added to wired pool >> and belongs to ARC, but appareantly this doesn't work well and WIRED: >> 1303.86 MB all the time. >> >> [1] http://pastebin.com/sQUyQbmm > > Try this. I the similar fix is needed for tmpfs, but there are some > more issues and pending rewrite, so I decided not to touch it. > > commit 8e5885bce1afecd419e40240a2d7ab90deb0392a > Author: Konstantin Belousov <kostik@pooma.home> > Date: Tue Feb 8 22:35:29 2011 +0200 > > Do not forget to activate the page > > diff --git a/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c > b/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c > index e8191b3..7343c72 100644 > --- a/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c > +++ b/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c What is this patch up against? I can't apply it to the STABLE. :(
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?op.vqlsazg6aevz08>