Date: Sat, 11 Jul 2009 13:39:03 -0700 From: Marcel Moolenaar <xcllnt@mac.com> To: rea-fbsd@codelabs.ru Cc: freebsd-current@freebsd.org, John Marshall <john.marshall@riverwillow.com.au> Subject: Re: 8.0-BETA1 bsdlabel broken? Message-ID: <A70794BC-F018-4F0A-9AF9-56E28D2B4845@mac.com> In-Reply-To: <TiR5kGIN59NiPk3Q5HjMiImYooQ@MbxgtlHN37ICHkxRO9kSrKasfoA> References: <v/OAX36A7OnJtyaNY4uYnXPs%2BOI@CWODRlDR5RMqbkBfR0/UzHcfNhE> <EC5F9AF8-2C2D-45DF-A1A2-8481EC73E426@mac.com> <20090710042106.GC31950@rwpc12.mby.riverwillow.net.au> <fX%2BVI6m2svXk4wDqOGQ3HIesgO8@jmKTY7juey8QgiyMw1P6k9Lb4sg> <20090710071023.GB32316@rwpc12.mby.riverwillow.net.au> <20090710112631.GE32316@rwpc12.mby.riverwillow.net.au> <3a142e750907100433y307f9b2bya1dc54953bdf5de2@mail.gmail.com> <0B1F6799-2FAC-4C01-A978-42E247979CAB@mac.com> <1z5niluEh3OBPNSdMbOMyoEwzX4@CWODRlDR5RMqbkBfR0/UzHcfNhE> <267A655F-13A6-4D79-A933-3A78854AC5FD@mac.com> <TiR5kGIN59NiPk3Q5HjMiImYooQ@MbxgtlHN37ICHkxRO9kSrKasfoA>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jul 11, 2009, at 11:15 AM, Eygene Ryabinkin wrote: > > OK, the attached patch should solve the issue in the bsdlabel: > it really uses the offset of the 'c' partition to make offsets > to be relative. Yes, that's the idea. I would add a safety check though: even though the 'c' partition is defined and reserved to mean the whole disk, there's nothing preventing creative souls from using the 'c' partition for something else. I would add a check to make sure that the offset of the 'c' partition is less than or equal to any of the offsets in the partition table before subtracting. >> As a special warning: you should not have both GEOM_PART_BSD >> and GEOM_BSD. My gut feeling tells me that you have both and >> that's why you have the mess you're having. > > Then I would add a bit stronger warning about the GEOM_BSD into > /usr/src/UPDATING -- the current one (from 20090320) is rather mild in > respect of the obsoletenness of GEOM_BSD. And since GEOM_PART_* > seem to > be included by-default, it will produce the mess I had seen when > GEOM_BSD is included too. It will be good to embed the checks for > incompatible options into config(8). I'll draft the needed patches > for config(8). I think It's better to remove the options (and code) altogether. -- Marcel Moolenaar xcllnt@mac.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A70794BC-F018-4F0A-9AF9-56E28D2B4845>