Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 17 Oct 2011 09:56:23 -0700 (PDT)
From:      Gerald Pfeifer <gerald@pfeifer.com>
To:        freebsd-toolchain@freebsd.org
Subject:   Re: [toolchain] disable -Wtautological-compare for clang
Message-ID:  <alpine.LNX.2.00.1110170955060.2807@gerinyyl.fvgr>
In-Reply-To: <20111017152548.GA66978@freebsd.org>
References:  <20111017152548.GA66978@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 17 Oct 2011, Alexander Best wrote:
> any chance we could disable -Wtautological-compare for clang? i don't 
> think comparing an unsigned int against < 0 is worth a warning. actually 
> it's always nice to have such a seatbelt, in case somebody changes the 
> type to int and forgets to introduce such a check.

I am on the fence on this one, for when I used the equivalent warning
in GCC this did found a number of real issues that I then addressed for
Wine (as an example).

Gerald



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LNX.2.00.1110170955060.2807>