Date: Thu, 14 Jul 2016 08:09:26 -0700 From: Conrad Meyer <cem@freebsd.org> To: Baptiste Daroussin <bapt@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r418510 - head/devel/elfutils Message-ID: <CAG6CVpVbsOe%2B7viyhjk=VxYR5LXUr%2BVe0YybREYSEoTiKgZL0A@mail.gmail.com> In-Reply-To: <20160714084653.quyjmu7g3e4f7d5b@ivaldir.etoilebsd.net> References: <201607140142.u6E1g9Sp056312@repo.freebsd.org> <20160714084653.quyjmu7g3e4f7d5b@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 14, 2016 at 1:46 AM, Baptiste Daroussin <bapt@freebsd.org> wrote: > Which is exactly why non ports committers are not supposed to commit in the ports > tree without a ports committer review/approval. Sorry. I'm doing my best with the porter's handbook, just like anyone else. > At least at quick glance there is this: > - post-patch expects gnulib to already be installed but gnulib is a build > dependency and not a patch dependency so not installed at the momemt you > needed it Why have a PATCH_DEPENDS distinct from BUILD_DEPENDS? > - automake is not supposed to be run like this The port doesn't need a full autoreconf, just automake. It is intended to work in isolation to configure.ac/configure.in. The porter's handbook did not seem to provide any better direction here. > https://people.freebsd.org/~bapt/elfutils.diff > > Should fix those 2 issues Please go ahead and commit. Thanks, Conrad
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpVbsOe%2B7viyhjk=VxYR5LXUr%2BVe0YybREYSEoTiKgZL0A>