Date: Fri, 14 Sep 2001 22:30:53 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Brian Somers <brian@freebsd-services.com> Cc: Jeroen Ruigrok van der Werven <asmodai@FreeBSD.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/sys cdefs.h Message-ID: <20010914221545.G18664-100000@delplex.bde.org> In-Reply-To: <200109141122.f8EBMYd29701@hak.lan.Awfulhak.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 14 Sep 2001, Brian Somers wrote: > > asmodai 2001/09/14 04:01:10 PDT > > > > Modified files: > > sys/sys cdefs.h > > Log: > > For old gcc/gcc-based compilers and non gcc compilers make sure to > > hide the __attribute__ gcc keyword. > > > > Reviewed and helped by: peter > > > > Revision Changes Path > > 1.37 +2 -1 src/sys/sys/cdefs.h > > It may be better to #define this as something that'll break the > compile. Code that uses gcc __attribute__s will probably break badly > if they're just ignored. Yes, this change is backward. It undoes the main part of rev.1.17. No special #define's are required to correctly break the compiles, since __attribute__(()) is already a syntax error. This regression may be related to breakage of lint(1). lint(1) now uses a wrong version of cpp, one that pre-defines __GNUC__. Since lint is not gcc, this defeats all the __GNUC__ ifdefs in <sys/cdefs.h>. In particular, __attributes__'s in important macros like __printflike are exposed to lint and lint barfs on important headers like <stdio.h> that expand these macros. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010914221545.G18664-100000>