Date: Wed, 23 Jul 2003 15:35:59 -0700 (PDT) From: Nate Lawson <nate@root.org> To: Mike Makonnen <mtm@identd.net> Cc: Peter Wemm <peter@FreeBSD.org> Subject: Re: cvs commit: src/sys/kern kern_umtx.c Message-ID: <20030723153526.O40342@root.org> In-Reply-To: <20030723220418.GA62833@kokeb.ambesa.net> References: <200307232029.h6NKTDHP031126@repoman.freebsd.org> <20030723220418.GA62833@kokeb.ambesa.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 23 Jul 2003, Mike Makonnen wrote: > On Wed, Jul 23, 2003 at 01:29:13PM -0700, Peter Wemm wrote: > > peter 2003/07/23 13:29:13 PDT > > sys/kern kern_umtx.c > > Log: > > Initialize 'blocked' to NULL. I think this was a real problem, but I > > am not sure about that. The lack of -Werror and the inline noise hid > > this for a while. > > No, I don't think it was a problem. It does get initialized before > use in the same if.. statement it is compared in: > > uq = umtx_lookup(td, umtx); > if (uq == NULL || > (uq != NULL && (blocked = TAILQ_FIRST(&uq->uq_tdq)) != NULL && > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > It might be against style, though. That isn't an initialization, that's assignment. -Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030723153526.O40342>