Date: Tue, 24 Jul 2018 18:15:07 +0200 From: Kirill Ponomarev <kp@krion.cc> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r475258 - in head/net/sniproxy: . files Message-ID: <20180724161506.GA79501@krion.cc> In-Reply-To: <20180724160850.GA57423@FreeBSD.org> References: <201807241450.w6OEoXZ6077220@repo.freebsd.org> <20180724160850.GA57423@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--AhhlLboLdkugWU4S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 07/24, Alexey Dokuchaev wrote: > On Tue, Jul 24, 2018 at 02:50:33PM +0000, Kirill Ponomarev wrote: > > New Revision: 475258 > > URL: https://svnweb.freebsd.org/changeset/ports/475258 > >=20 > > Log: > > Utilize SOCK_NONBLOCK instead of O_NONBLOCK > >=20 > > Added: head/net/sniproxy/files/patch-src_connection.c > > ... > > +- O_NONBLOCK); > > ++ SOCK_NONBLOCK); >=20 > It would be nice if commit message also included the rationale for this > change (per our 30%-what-70%-why rule). accept4() is using SOCK_NONBLOCK on FreeBSD instead of O_NONBLOCK which is a case on Linux. --AhhlLboLdkugWU4S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEJCHRFhEAQujKni1pDyI9/LMCykUFAltXUIoACgkQDyI9/LMC ykWEUAgAjfjaFtx0D2h8aaIJ47t9zDYk6PEbsI40yF89HZRbJq6IdK6vdOjOUSOE bjeRSs+tNxPWPGWZBQjaKVGs48Y0RoJxh0rcHZqWt7x16iUpHCwq7knN+UWO/B8n DatS8LhyPF0T7+qe5SjXwqIEgMcU6sFH0Kw+wL2zlMNyy2FO99FZP5PbSMfRINFi jl2ovg1HpsAdGE6o34S77BiyEjSkqwePC9x40UlzxJzvvLemsFTAgF0dyZfQKcNw IgSt/VGOZ9ptQkaLDZEzMr+xyOuPFjc3Zusp1kryWaAneQhUY6kULoeOEcTsrJLi jIlQX71s+M9GQaxBOpsGUS3l7Oc21Q== =Fkge -----END PGP SIGNATURE----- --AhhlLboLdkugWU4S--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180724161506.GA79501>