Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 7 Nov 2013 21:24:26 GMT
From:      Michael Gmelin <freebsd@grem.de>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/183763: devel/py-yaml: Confusing OPTIONS
Message-ID:  <201311072124.rA7LOQ8b080222@oldred.freebsd.org>
Resent-Message-ID: <201311072130.rA7LU0YD025389@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         183763
>Category:       ports
>Synopsis:       devel/py-yaml: Confusing OPTIONS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Nov 07 21:30:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Michael Gmelin
>Release:        9.1-RELEASE
>Organization:
Grem Equity GmbH
>Environment:
FreeBSD bsd64.grem.de 9.1-RELEASE-p2 FreeBSD 9.1-RELEASE-p2 #5 r249052M: Fri May 31 17:50:16 UTC 2013     root@srv05:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
The purpose of this port is providing YAML support to python, yet it defines

OPTIONS_DEFINE= YAML

which is not enabled by default and shown to the user as

[ ] YAML    YAML format or parser support
 
As far as I can tell this option enables the libyaml plugin in PyYAML.
LibYAML is written in C and as a result PyYAML is supposed to run
faster/nicer etc. Unfortunately the current option name doesn't make
this clear.

I would suggest to use a new option called LIBYAML, e.g.

OPTIONS_DEFINE= LIBYAML
LIBYAML_DESC= Use textproc/libyaml for faster parsing

and change

.if ${PORT_OPTIONS:MYAML}

to

.if ${PORT_OPTIONS:MLIBYAML}


Since I think that the general option YAML is about supporting yaml (and might be set globally by users) this might be a cleaner solution (alternatives would be overriding the description locally or change the default option description in /usr/ports/Mk/bsd.options.desc.mk to say "use libyaml", which most likely will lead to other problems)


And change the 
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201311072124.rA7LOQ8b080222>