Date: Sun, 8 Jul 2018 09:55:34 -0600 From: Sean Bruno <sbruno@freebsd.org> To: Mark Johnston <markj@freebsd.org> Cc: Andrew Turner <andrew@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334880 - head/sys/dev/vnic Message-ID: <5483bcd6-f3bc-8b78-ee51-3bf3c2a1c2da@freebsd.org> In-Reply-To: <20180708152621.GB18193@pesky> References: <201806091447.w59ElnpU026396@repo.freebsd.org> <20180707174351.GA95934@pesky> <ef680451-5750-e0cd-27b5-852fc8e74eb8@freebsd.org> <20180708152621.GB18193@pesky>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --U0uwA7FJ9ZOpcQwwrjY13Yxih2rrWtbJH Content-Type: multipart/mixed; boundary="Fthl8wJcqgk2RIIFbKMrPvErFg9rm1sal"; protected-headers="v1" From: Sean Bruno <sbruno@freebsd.org> To: Mark Johnston <markj@freebsd.org> Cc: Andrew Turner <andrew@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <5483bcd6-f3bc-8b78-ee51-3bf3c2a1c2da@freebsd.org> Subject: Re: svn commit: r334880 - head/sys/dev/vnic References: <201806091447.w59ElnpU026396@repo.freebsd.org> <20180707174351.GA95934@pesky> <ef680451-5750-e0cd-27b5-852fc8e74eb8@freebsd.org> <20180708152621.GB18193@pesky> In-Reply-To: <20180708152621.GB18193@pesky> --Fthl8wJcqgk2RIIFbKMrPvErFg9rm1sal Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 07/08/18 09:26, Mark Johnston wrote: > On Sun, Jul 08, 2018 at 09:10:27AM -0600, Sean Bruno wrote: >> >> >> On 07/07/18 11:43, Mark Johnston wrote: >>> On Sat, Jun 09, 2018 at 02:47:49PM +0000, Andrew Turner wrote: >>>> Author: andrew >>>> Date: Sat Jun 9 14:47:49 2018 >>>> New Revision: 334880 >>>> URL: https://svnweb.freebsd.org/changeset/base/334880 >>>> >>>> Log: >>>> In the ThunderX BGX network driver we were skipping the NULL termi= nator >>>> when parsing the phy type, however this is included in the length = returned >>>> by OF_getprop. To fix this stop ignoring the terminator. >>>> =20 >>>> PR: 228828 >>>> Reported by: sbruno >>>> Sponsored by: DARPA, AFRL >>> >>> This seems to break vnic on packet.net ThunderXs. In particular, VF >>> creation fails. It seems the problem in my case is that there are >>> multiple PHY devices in the device tree, e.g., xfi@0, xfi@1. With th= is >>> change, bgx_fdt_phy_name_match() fails to match against any device >>> containing a unit address in the node name. >>> >> >> >> Huh ... this was *required* to get the ThunderXs we have in the FreeBS= D >> cluster to work at all. o.0 >> >> I guess "someone" needs to contact "someone" to figure out which is >> correct or we need to replace our FreeBSD cluster machines with ones >> that work like the packet.net machines? >=20 > I think the current code works fine if there's only one PHY device, so > my problem is probably just the result of having a different hardware > setup. We can probably fix the code to handle both cases. Could you > mail me the output of "ofwdump -ap" from the cluster machine? >=20 >=20 I dropped the output here: https://people.freebsd.org/~sbruno/ofwdump.txt sean --Fthl8wJcqgk2RIIFbKMrPvErFg9rm1sal-- --U0uwA7FJ9ZOpcQwwrjY13Yxih2rrWtbJH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEE6MTp+IA1BOHj9Lo0veT1/om1/LYFAltCM/ZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEU4 QzRFOUY4ODAzNTA0RTFFM0Y0QkEzNEJERTRGNUZFODlCNUZDQjYACgkQveT1/om1 /LbCeQf/f+eJK3HoXZNE0GXy13SochYy32P3nhCUNg4zZ+i0Pl7nXalRjKBbXJE3 8SRKU7xbOObcw41BBKqbEr8kAf9U4xMwVkt+K4iBReaMoPLuscHNlm+THwnDoKff O6l2zpqP7nCc5A1uG8gjOnbyx8ssnmDZ9AS6cBuBRRRAsBVY/3cfmK+jeTIT35Se ufjE9CWHjKfhNvBOpXgoA0Jhe4Hbo4mWP2lJrFYRTBinefykG+61RdehtzovikoU tozgl3zJvVF8mYqUAWnJx1oE2Huq9D9MkDESZgBKySTfexWvaobPmsQ1Js8zjS08 TLDcQJccsvCv1o9N0q7Z9n5swZxAGw== =GB/A -----END PGP SIGNATURE----- --U0uwA7FJ9ZOpcQwwrjY13Yxih2rrWtbJH--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5483bcd6-f3bc-8b78-ee51-3bf3c2a1c2da>