Date: Wed, 11 May 2016 21:38:26 +0000 From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: Andrew Turner <andrew@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r299467 - in head: share/man/man9 sys/dev/pci Message-ID: <ADDCB1BB-E6BC-4010-AF38-4264EB6AEF81@FreeBSD.org> In-Reply-To: <201605111707.u4BH7UXs040026@repo.freebsd.org> References: <201605111707.u4BH7UXs040026@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 11 May 2016, at 17:07 , Andrew Turner <andrew@freebsd.org> wrote: >=20 > Author: andrew > Date: Wed May 11 17:07:29 2016 > New Revision: 299467 > URL: https://svnweb.freebsd.org/changeset/base/299467 >=20 > Log: > Add a new get_id interface to pci and pcib. This will allow us to = both > detect failures, and get different PCI IDs. >=20 > For the former the interface returns an int to signal an error. The = ID is > returned at a uintptr_t * argument. >=20 > For the latter there is a type argument that allows selecting the ID = type. > This only specifies a single type, however a MSI type will be added > to handle the need to find the ID the hardware passes to the ARM = GICv3 > interrupt controller. >=20 > A follow up commit will be made to remove pci_get_rid. >=20 > Reviewed by: jhb, rstone > Obtained from: ABT Systems Ltd > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D6239 Hi, seems gcc, I guess it is, doesn=E2=80=99t like your change: In file included from = /scratch/tmp/bz/head.svn/sys/sparc64/isa/ofw_isa.c:78: ./pcib_if.h:166: warning: 'enum pci_id_type' declared inside parameter = list ./pcib_if.h:166: warning: its scope is only this definition or = declaration, which is probably not what you want ./pcib_if.h:169: warning: 'enum pci_id_type' declared inside parameter = list ./pcib_if.h:169: error: parameter 3 ('type') has incomplete type ./pcib_if.h: In function 'PCIB_GET_ID': ./pcib_if.h:173: error: type of formal parameter 3 is incomplete
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ADDCB1BB-E6BC-4010-AF38-4264EB6AEF81>