Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 3 Dec 2010 19:17:23 +0200
From:      Kostik Belousov <kostikbel@gmail.com>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r216150 - head/sys/kern
Message-ID:  <20101203171723.GD2392@deviant.kiev.zoral.com.ua>
In-Reply-To: <201012031615.oB3GFimB096704@svn.freebsd.org>
References:  <201012031615.oB3GFimB096704@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--4K4B5pKFuxi3JHFN
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 03, 2010 at 04:15:44PM +0000, Konstantin Belousov wrote:
> Author: kib
> Date: Fri Dec  3 16:15:44 2010
> New Revision: 216150
> URL: http://svn.freebsd.org/changeset/base/216150
>=20
> Log:
>   Reviewed by:	jeff, rwatson
>   MFC after:	1 week

Oops, I failed to use proper -F file with svn ci :(.

The commit log is (or, was supposed to be):

If unix socket has a unix socket attached as the rights that has a
unix socket attached as the rights that has a unix socket attached as
the rights ... Kernel may overflow the stack on attempt to close such
socket.

Only close the rights file in the context of the current close if the
file is not unix domain socket. Otherwise, postpone the work to
taskqueue, preventing unlimited recursion.

The pass of the unix domain sockets over the SCM_RIGHTS message
control is not widely used, and more, the close of the socket with
still attached rights is mostly an application failure. The change
should not affect the performance of typical users of SCM_RIGHTS.

Reviewed by:	jeff, rwatson
MFC after:	1 week

--4K4B5pKFuxi3JHFN
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (FreeBSD)

iEYEARECAAYFAkz5JiIACgkQC3+MBN1Mb4gtZwCfT9LQRlUYqpZW82i6ADphthW1
pvwAoIwKNsIdt3E0TAzbtdee8agNaGTu
=DLKL
-----END PGP SIGNATURE-----

--4K4B5pKFuxi3JHFN--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101203171723.GD2392>