Date: Mon, 25 Feb 2019 17:34:21 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 235944] jedec_dimm(4) does not attach to KFA2 (aka Galax) Hall of Fame DDR4 sticks Message-ID: <bug-235944-227-1gUdomLASf@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-235944-227@https.bugs.freebsd.org/bugzilla/> References: <bug-235944-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D235944 --- Comment #21 from Andriy Gapon <avg@FreeBSD.org> --- Sorry, I've been inattentive again. What if that bit lies, e.g., because of a vendor's mistake... Then, we would fail here: if (byte & 0x80) { tsod_present =3D true; rc =3D jedec_dimm_readw_be(sc, TSOD_REG_MANUFACTURER, &vend= orid); if (rc !=3D 0) { device_printf(dev, "failed to read TSOD Manufacturer ID\n"); goto out; } And we see that in comment #0: > jedec_dimm0: failed to read TSOD Manufacturer ID > device_attach: jedec_dimm0 attach returned 1 P.S. it also seems that smbus error codes ideally need translating to "norm= al" error codes. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-235944-227-1gUdomLASf>