Date: Fri, 5 Feb 2016 12:26:38 -0800 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Mark Johnston <markj@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r295330 - head/sys/vm Message-ID: <20160205202638.GM72286@FreeBSD.org> In-Reply-To: <201602051935.u15JZr85032701@repo.freebsd.org> References: <201602051935.u15JZr85032701@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Mark, thanks! Me culpa :( On Fri, Feb 05, 2016 at 07:35:53PM +0000, Mark Johnston wrote: M> Author: markj M> Date: Fri Feb 5 19:35:53 2016 M> New Revision: 295330 M> URL: https://svnweb.freebsd.org/changeset/base/295330 M> M> Log: M> Plug a vm_page leak introduced in r292373. M> M> Reported by: vangyzen M> M> Modified: M> head/sys/vm/sg_pager.c M> M> Modified: head/sys/vm/sg_pager.c M> ============================================================================== M> --- head/sys/vm/sg_pager.c Fri Feb 5 18:17:37 2016 (r295329) M> +++ head/sys/vm/sg_pager.c Fri Feb 5 19:35:53 2016 (r295330) M> @@ -189,6 +189,9 @@ sg_pager_getpages(vm_object_t object, vm M> VM_OBJECT_WLOCK(object); M> TAILQ_INSERT_TAIL(&object->un_pager.sgp.sgp_pglist, page, plinks.q); M> vm_page_replace_checked(page, object, offset, m[0]); M> + vm_page_lock(m[0]); M> + vm_page_free(m[0]); M> + vm_page_unlock(m[0]); M> m[0] = page; M> page->valid = VM_PAGE_BITS_ALL; M> M> _______________________________________________ M> svn-src-all@freebsd.org mailing list M> https://lists.freebsd.org/mailman/listinfo/svn-src-all M> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160205202638.GM72286>