Date: Thu, 19 Jul 2018 20:27:38 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Michael Tuexen <tuexen@freebsd.org> Cc: cem@freebsd.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r336503 - in head/sys: netinet netinet6 Message-ID: <20180719202738.GA69018@FreeBSD.org> In-Reply-To: <F9ECD259-049F-45FB-A104-678749564BCC@freebsd.org> References: <201807191933.w6JJXhof018383@repo.freebsd.org> <CAG6CVpWMWAZW_K47X1kXFS-JJo8Nc3zewKCzjRb7tr5BUsRAUA@mail.gmail.com> <F9ECD259-049F-45FB-A104-678749564BCC@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 19, 2018 at 04:23:27PM -0400, Michael Tuexen wrote: > > On 19. Jul 2018, at 16:11, Conrad Meyer <cem@freebsd.org> wrote: > > These changes mostly seem like style regressions, rather than > > improvements. (Not to mention, largescale churn like this makes it > > more difficult for future readers to research history (confusing tools > > like "git/svn blame").) > > We have upstream code and run this to an formatter tool which depends > on ident, which has been changed recently. Unfortunately, I also ran > an older version of the script, so I reverted this in > https://svnweb.freebsd.org/changeset/base/336508 > and committed a version really only showing the differences related to > the ident changes in > https://svnweb.freebsd.org/changeset/base/336511 Thanks for fixing, but you might find doing "svn diff" prior to commit very handy next time (no offense). ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180719202738.GA69018>