Date: Thu, 7 Aug 2003 07:44:59 -0700 (PDT) From: Nate Lawson <nate@root.org> To: "Daniel C. Sobral" <dcs@tcoip.com.br> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/contrib/dev/acpica acfreebsd.h Message-ID: <20030807073437.X75796@root.org> In-Reply-To: <3F325F9A.8020906@tcoip.com.br> References: <200308070446.h774kHAq037869@repoman.freebsd.org> <3F325F9A.8020906@tcoip.com.br>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 7 Aug 2003, Daniel C. Sobral wrote: > This commit broke world on loader. Thanks, already fixed. > The problem is sys/boot/i386/libi386/biosacpi.c, which includes this > file since your rev 1.5 commit. :-) No, biosacpi.c does not include ctype.h. The commit you reference added acconfig.h, which is just a set of defines. > Specifically, stand.h, which is included by anything that uses libstand > functions (such as is the case with biosacpi.c), is mutually exclusive > with ctype.h. > > Specifically: > > /* Not building kernel code, so use libc */ > > is false on both accounts for loader. :-) Loader is not kernel, alright, > but neither does it use libc. > > Since I'm not familiar with how, exactly, is acfreebsd.h used, I can't > offer more advise. :-) > > Tricky, eh? :-) Since biosacpi is so small and doesn't use any Acpi* functions, the ACPI_USE_STANDARD_HEADERS define doesn't affect it in any way. The way it works is that acfreebsd.h sets up some compatibility includes/defines so that acpica builds ok. It's needed to make the structs used by biosacpi.c (Xsdt, Rsdt) work. > Shouldn't ctype.h be a required include to anything including acfreebsd.h? That could be one way. I posted the problem to current@ because I don't want to increase header pollution. -Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030807073437.X75796>