Date: Wed, 29 May 2013 11:44:44 -0400 From: Adam Weinberger <adamw@adamw.org> To: Jason Helfman <jgh@freebsd.org> Cc: svn-ports-head@freebsd.org, owner-ports-committers@freebsd.org, Martin Wilke <miwi@freebsd.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Boris Samorodov <bsam@passap.ru> Subject: Re: svn commit: r319306 - in head/shells/fish: . files Message-ID: <3f5b65bcdb94d31d4e512585a160a997@mail.adamw.org> In-Reply-To: <CAMuy=%2Bgb2WMay7uKF7Pm7%2B9A56Xm2T8u71%2BuJtpE6R-mhBT7Mg@mail.gmail.com> References: <201305281350.r4SDo0QX088856@svn.freebsd.org> <51A4F14F.7050903@passap.ru> <CAMuy=%2Bgb2WMay7uKF7Pm7%2B9A56Xm2T8u71%2BuJtpE6R-mhBT7Mg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2013/05/29 01:00, Jason Helfman wrote:
> On Tue, May 28, 2013 at 11:02 AM, Boris Samorodov <bsam@passap.ru>
> wrote:
>
>> 28.05.2013 17:50, Martin Wilke пишет:
>>
>>> post-install:
>>
>>> +.for i in fish fish_indent fish_pager fishd mimedb
>>> + @${STRIP_CMD} ${PREFIX}/bin/${i}
>>> +.endfor
>>
>> Do we really allow dealing with files at $PREFIX?
>
> This is the first time I've seen something like this, but I can't say
> it hasn't done before without more investigation. Beyond this, I don't
> see why this couldn't be done as a post-build target, but I also don't
> know if there are any issues preventing this route.
Many autotools-based programs relink libraries and executables during
the install target. Sometimes waiting until it's been placed into PREFIX
is the only way to access the final edition.
Also I'm not really sure why we wouldn't allow dealing with files at
PREFIX in the manner that miwi's commit handles it.
To me, I'd think the bigger question is why it isn't stripping the
executables already as part of the install target, as autotools stuff
usually DTRT.
# Adam
---
Adam Weinberger
adamw@adamw.org
http://www.adamw.org
>
> -jgh
>
> --
> Jason Helfman | FreeBSD Committer
> jgh@FreeBSD.org | http://people.freebsd.org/~jgh [1] | The
> Power to Serve
>
>
> Links:
> ------
> [1] http://people.freebsd.org/%7Ejgh
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3f5b65bcdb94d31d4e512585a160a997>