Date: Wed, 26 Aug 2009 21:55:59 GMT From: Chris Cowart <ccowart@rescomp.berkeley.edu> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/138214: [patch] sysutils/syslog-ng3 configure doesn't detect openssl Message-ID: <200908262155.n7QLtxPV020632@www.freebsd.org> Resent-Message-ID: <200908262200.n7QM02b1089555@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 138214 >Category: ports >Synopsis: [patch] sysutils/syslog-ng3 configure doesn't detect openssl >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Aug 26 22:00:02 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Chris Cowart >Release: 7.1-RELEASE >Organization: UC Berkeley - RSSP-IT >Environment: FreeBSD test-pitfall.housing.berkeley.edu 7.1-RELEASE-p6 FreeBSD 7.1-RELEASE-p6 #0: Fri Jul 3 11:03:46 PDT 2009 root@test-pitfall.housing.berkeley.edu:/usr/obj/usr/src/sys/RCBSD_REL7 amd64 >Description: The syslog-ng3 configure script expects an openssl.pc to correctly auto-configure openssl support. As this file does not exist, a cryptic error about gnome-config is printed to the screen and openssl support is set to "no". This disables a fantastic feature of syslog-ng3, which is support for tcp/tls logging. Given openssl is part of the base system, it'll always be there, so there's not really any reason to let configure make this painful mistake. >How-To-Repeat: sudo make -C /usr/ports/sysutils/syslog-ng3 install >Fix: Using ./configure --help as a guide, I discovered the OPENSSL_CFLAGS and OPENSSL_LIBS environment variables that can be used to override the use of pkg-config for openssl detection. I played around with USE_OPENSSL=yes, which didn't wasn't enough. The port maintainer may see a better way to do this, but the contained patch causes syslog-ng3 to properly compile with TLS support. Patch attached with submission follows: diff -rub /usr/ports/sysutils/syslog-ng3/Makefile /home/ccowart/src/syslog-ng3/Makefile --- /usr/ports/sysutils/syslog-ng3/Makefile 2009-07-14 11:42:12.000000000 -0700 +++ /home/ccowart/src/syslog-ng3/Makefile 2009-08-25 16:51:07.000000000 -0700 @@ -7,7 +7,7 @@ PORTNAME= syslog-ng PORTVERSION= 3.0.3 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= sysutils MASTER_SITES= http://www.balabit.com/downloads/files/syslog-ng/sources/$(PORTVERSION)/source/ PKGNAMESUFFIX= 3 @@ -27,13 +27,16 @@ USE_GNOME= glib20 SUB_FILES= pkg-message SUB_LIST= RC_SUBR_SUFFIX=${RC_SUBR_SUFFIX} +USE_OPENSSL=yes LIBNET_CONFIG?= ${LOCALBASE}/bin/libnet11-config CONFIGURE_ARGS= --sysconfdir=${LOCALBASE}/etc --localstatedir=/var/db \ --enable-dynamic-linking --with-libnet=${LOCALBASE}/bin -CONFIGURE_ENV= CFLAGS="`${LIBNET_CONFIG} --cflags`" \ - LDFLAGS="`${LIBNET_CONFIG} --libs`" +CONFIGURE_ENV= CFLAGS="`${LIBNET_CONFIG} --cflags` ${CFLAGS}" \ + LDFLAGS="`${LIBNET_CONFIG} --libs` ${LDFLAGS}" \ + OPENSSL_CFLAGS="${OPENSSL_CFLAGS}" \ + OPENSSL_LIBS="${OPENSSL_LDFLAGS} -lcrypto -lssl" .if defined(WITH_TCP_WRAPPERS) CONFIGURE_ARGS+=--enable-tcp-wrapper >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200908262155.n7QLtxPV020632>