Date: Wed, 9 Nov 2016 10:45:54 -0500 From: Diane Bruce <db@db.net> To: marino@freebsd.org Cc: Jan Beich <jbeich@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r425789 - head/comms/fldigi Message-ID: <20161109154554.GA2363@night.db.net> In-Reply-To: <7a648386-b559-67d2-4767-6dcf9d05c5de@marino.st> References: <201611091051.uA9ApZlS024266@repo.freebsd.org> <7a648386-b559-67d2-4767-6dcf9d05c5de@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 09, 2016 at 07:41:28AM -0600, John Marino wrote: I've got fldigi 3.23.15 in poudriere now. I had a simple fix for current version but might as well keep the ports churn down. Here's the fix for previous version. --- src/main.cxx.orig 2016-11-06 22:37:25 UTC +++ src/main.cxx @@ -1489,7 +1489,7 @@ double speed_test(int converter, unsigne src.data_in = new float[src.input_frames]; src.data_out = new float[src.output_frames]; - memset(src.data_in, 0, src.input_frames * sizeof(float)); + memset((void *)&src.data_in, 0, src.input_frames * sizeof(float)); // warm up src_simple(&src, converter, 1); > On 11/9/2016 04:51, Jan Beich wrote: > > Author: jbeich > > Date: Wed Nov 9 10:51:35 2016 > > New Revision: 425789 > > URL: https://svnweb.freebsd.org/changeset/ports/425789 > > > > Log: > > comms/fldigi: mark BROKEN after r425442 > > > > src/main.cxx:1492:2: error: no matching function for call to 'memset' > > memset(src.data_in, 0, src.input_frames * sizeof(float)); > > ^~~~~~ > > /usr/include/string.h:67:7: note: candidate function not viable: no known conversion from 'const float *' to 'void *' for 1st argument; take the address of the argument with & > > void *memset(void *, int, size_t); > > ^ > > > > Reported by: pkg-fallout > > Pointy hat to: @bapt (and upstream) > > > > Modified: > > head/comms/fldigi/Makefile (contents, props changed) > > > > Modified: head/comms/fldigi/Makefile > > ============================================================================== > > --- head/comms/fldigi/Makefile Wed Nov 9 10:51:23 2016 (r425788) > > +++ head/comms/fldigi/Makefile Wed Nov 9 10:51:35 2016 (r425789) > > @@ -18,6 +18,8 @@ LIB_DEPENDS= libsamplerate.so:audio/libs > > libboost_system.so:devel/boost-libs\ > > libfltk.so:x11-toolkits/fltk > > > > +BROKEN= Fails to build against libsamplerate-0.1.9 > > + > > USE_CXXSTD= gnu++0x > > GNU_CONFIGURE= yes > > USES= compiler:c++11-lib execinfo gmake perl5 pkgconfig shebangfix > > > > zrj was able to fix this in dports with a -fpermissive flag: > > https://github.com/DragonFlyBSD/DeltaPorts/commit/027deb64600a338f1e0c080933f4e5b34c5533f4 > > "New audio/libsamplerate has const float in SRC_DATA stuct, yet here > it is used with non-c++ memset(that is C)." > > with that change, it builds for us. > > John > > > > > > --- > This email has been checked for viruses by Avast antivirus software. > https://www.avast.com/antivirus > > > -- - db@FreeBSD.org db@db.net http://www.db.net/~db
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161109154554.GA2363>