Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 6 Jan 2002 21:42:24 -0600
From:      "Jacques A. Vidrine" <n@nectar.cc>
To:        Jeremy Lea <reg@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: ports/net/gnomeicu/files patch-src::icu_db.c
Message-ID:  <20020106214224.A67906@hellblazer.nectar.cc>
In-Reply-To: <20020106220536.N73815@squall.waterspout.com>; from will@csociety.org on Sun, Jan 06, 2002 at 10:05:36PM -0500
References:  <200201062053.g06KrMC19409@freefall.freebsd.org> <20020106213902.GA88137@madman.nectar.cc> <20020106220536.N73815@squall.waterspout.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jan 06, 2002 at 10:05:36PM -0500, Will Andrews wrote:
> It's possible that there is an OS that doesn't have stdlib.h.  

I highly doubt that is true anymore, particularly where GNOME runs.
If you don't have <stdlib.h>, you are not using C (since 1989 or
earlier).  

> So
> autoconf in gnomeicu presumably does a check for it and defines
> HAVE_STDLIB_H if it exists.  This is the correct fix, if reg@
> wishes to get this merged into GnomeICU sources.  

No, the correct fix is to have autoconf check for malloc.h, and define
HAVE_MALLOC_H if it exists.  Or just ignore malloc.h entirely, since
there is no malloc.h in any C standard that I know, nor in POSIX '88
or later, nor XPG3 or later.  K&R's `The C Programming Language'
doesn't mention it, nor does Stevens's APUE.

The GnomeICU author is reasonable and appreciates bug fixes.

> Although I'd
> just take out #else #include <malloc.h> personally.

And just leave the HAVE_STDLIB_H?  That seems silly.

Cheers,
-- 
Jacques A. Vidrine <n@nectar.cc>                     http://www.nectar.cc/
NTT/Verio SME           .      FreeBSD UNIX      .        Heimdal Kerberos
jvidrine@verio.net      .   nectar@FreeBSD.org   .           nectar@kth.se

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020106214224.A67906>