Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 31 Jan 2009 18:06:34 +0000 (UTC)
From:      "Bjoern A. Zeeb" <bz@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r187960 - in head/sys/fs: nwfs smbfs
Message-ID:  <200901311806.n0VI6Yh9030777@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: bz
Date: Sat Jan 31 18:06:34 2009
New Revision: 187960
URL: http://svn.freebsd.org/changeset/base/187960

Log:
  After r186194 the *fs_strategy() functions always return 0.
  So we are no longer interested in the error returned from
  the *fs_doio() functions. With that we can remove the
  error variable as its value is unused now.
  
  Submitted by:	Christoph Mallon christoph.mallon@gmx.de

Modified:
  head/sys/fs/nwfs/nwfs_vnops.c
  head/sys/fs/smbfs/smbfs_vnops.c

Modified: head/sys/fs/nwfs/nwfs_vnops.c
==============================================================================
--- head/sys/fs/nwfs/nwfs_vnops.c	Sat Jan 31 17:36:22 2009	(r187959)
+++ head/sys/fs/nwfs/nwfs_vnops.c	Sat Jan 31 18:06:34 2009	(r187960)
@@ -784,7 +784,6 @@ static int nwfs_strategy (ap) 
 	struct buf *bp=ap->a_bp;
 	struct ucred *cr;
 	struct thread *td;
-	int error = 0;
 
 	NCPVNDEBUG("\n");
 	if (bp->b_flags & B_ASYNC)
@@ -801,7 +800,7 @@ static int nwfs_strategy (ap) 
 	 * otherwise just do it ourselves.
 	 */
 	if ((bp->b_flags & B_ASYNC) == 0 )
-		error = nwfs_doio(ap->a_vp, bp, cr, td);
+		(void)nwfs_doio(ap->a_vp, bp, cr, td);
 	return (0);
 }
 

Modified: head/sys/fs/smbfs/smbfs_vnops.c
==============================================================================
--- head/sys/fs/smbfs/smbfs_vnops.c	Sat Jan 31 17:36:22 2009	(r187959)
+++ head/sys/fs/smbfs/smbfs_vnops.c	Sat Jan 31 18:06:34 2009	(r187960)
@@ -850,7 +850,6 @@ smbfs_strategy (ap) 
 	struct buf *bp=ap->a_bp;
 	struct ucred *cr;
 	struct thread *td;
-	int error = 0;
 
 	SMBVDEBUG("\n");
 	if (bp->b_flags & B_ASYNC)
@@ -863,7 +862,7 @@ smbfs_strategy (ap) 
 		cr = bp->b_wcred;
 
 	if ((bp->b_flags & B_ASYNC) == 0 )
-		error = smbfs_doio(ap->a_vp, bp, cr, td);
+		(void)smbfs_doio(ap->a_vp, bp, cr, td);
 	return (0);
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200901311806.n0VI6Yh9030777>