Date: Sat, 22 Oct 2016 08:14:00 -0500 From: Justin Hibbits <chmeeedalf@gmail.com> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Justin Hibbits <jhibbits@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r307761 - in head: . contrib/binutils/bfd contrib/gcc/config/rs6000 gnu/lib/libgcc gnu/lib/libgomp gnu/usr.bin/binutils gnu/usr.bin/cc gnu/usr.bin/cc/cc_tools gnu/usr.bin/cc/include gnu... Message-ID: <A879A0D2-2AAE-47A5-8E76-FD8247973B87@gmail.com> In-Reply-To: <20161022124301.GZ54029@kib.kiev.ua> References: <201610220157.u9M1vFXx080331@repo.freebsd.org> <20161022122017.GY54029@kib.kiev.ua> <20161022124301.GZ54029@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Oct 22, 2016, at 7:43 AM, Konstantin Belousov wrote: > On Sat, Oct 22, 2016 at 03:20:17PM +0300, Konstantin Belousov wrote: >> On Sat, Oct 22, 2016 at 01:57:15AM +0000, Justin Hibbits wrote: >>> Author: jhibbits >>> Date: Sat Oct 22 01:57:15 2016 >>> New Revision: 307761 >>> URL: https://svnweb.freebsd.org/changeset/base/307761 >>> >>> Log: >>> Create a new MACHINE_ARCH for Freescale PowerPC e500v2 >> >>> Added: >>> head/lib/libc/powerpcspe/sys/ptrace.S (contents, props changed) >> >> This is not needed, libc provides MI implementation in libc/sys/ >> ptrace.c. > > Why the decision to copy whole lib/libc/powerpc to lib/libc/powerpcspe > was used to create the architecture ? I did a primitive-science > overview, and got total ~2300 lines in lib/libc/powerpcspe, while > $ diff -Nrua lib/libc/powerpc lib/libc/powerpcspe | diffstat -p0 | > tail -1 > 16 files changed, 240 insertions(+), 174 deletions(-) > > It seems to be possible to only create several new files, like > *setjmp.S and fp*.c, and reuse existing stock files from libc/powerpc > for anything else. > > I am the one who does most of the sweeping changes over libc, and > I am somewhat saddened by addition of almost identical copy of the > existing architecture files which need to be maintained together with > the original. To be honest, I didn't think it was the right way either, but wasn't completely certain (and admittedly didn't try) that I could have two files with the same names, one in powerpc one in powerpcspe, and have it ignore the powerpc one if it exists in powerpcspe. libc's Makefile includes ${MACHINE_ARCH}/Makefile.inc, unless it doesn't exist in which case it includes ${MACHINE_CPUARCH}/ Makefile.inc, I'll see if I can consolidate them, but do you have a recommendation of the best way to do it? I also didn't really like the code duplication, but couldn't think of an easy/good way to do so. Now that we've chatted on IRC a bit about this, I'll take your suggestion and create some Makefile.common files to share between powerpc and powerpcspe. It may take a couple days depending on my available time. - Justin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A879A0D2-2AAE-47A5-8E76-FD8247973B87>