Date: Sat, 07 Jan 2017 14:31:28 -0500 From: "George Neville-Neil" <gnn@freebsd.org> To: "Mark Johnston" <markj@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r311225 - head/sys/netinet Message-ID: <AC05F949-03EA-4A2C-8AF6-3C77A9A057D8@freebsd.org> In-Reply-To: <4C01D080-64D9-4862-AFD5-42CC49B5CC0B@freebsd.org> References: <201701040219.v042JDEk026544@repo.freebsd.org> <20170104182630.GA26522@wkstn-mjohnston.west.isilon.com> <4C01D080-64D9-4862-AFD5-42CC49B5CC0B@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7 Jan 2017, at 14:23, George Neville-Neil wrote: > On 4 Jan 2017, at 13:26, Mark Johnston wrote: > >> On Wed, Jan 04, 2017 at 02:19:13AM +0000, George V. Neville-Neil >> wrote: >>> Author: gnn >>> Date: Wed Jan 4 02:19:13 2017 >>> New Revision: 311225 >>> URL: https://svnweb.freebsd.org/changeset/base/311225 >>> >>> Log: >>> Fix DTrace TCP tracepoints to not use mtod() as it is both >>> unnecessary and >>> dangerous. Those wanting data from an mbuf should use DTrace >>> itself to get >>> the data. >> >> I think you also need to update the types in in_kdtrace.c, and add a >> translator for struct mbuf * to ipinfo_t. > > Fair points. > Actually, following up to myself, this does not need to be done just yet. The pkt_info stuff is currently always NULL. I'm working on a copyoutmbuf() subroutine that will make all of this much cleaner. Best, George
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AC05F949-03EA-4A2C-8AF6-3C77A9A057D8>