Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 24 Sep 2013 12:14:58 +0400
From:      Boris Samorodov <bsam@passap.ru>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Rusmir Dusko <nemysis@FreeBSD.org>, "'ports-committers@FreeBSD.org'" <ports-committers@FreeBSD.org>
Subject:   Re: svn commit: r327791 - in head/graphics/eos-movrec: . files
Message-ID:  <52414A02.7000900@passap.ru>
In-Reply-To: <20130923064949.GA79560@FreeBSD.org>
References:  <201309210613.r8L6Dcqf092555@svn.freebsd.org> <20130923055820.GA62466@FreeBSD.org> <20130923064949.GA79560@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------090105040308010107030601
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

23.09.2013 10:49, Alexey Dokuchaev пишет:
> On Mon, Sep 23, 2013 at 05:58:20AM +0000, Alexey Dokuchaev wrote:

>> When I first ported this nice little program, it was simple GUI application
>> (hence USE_QT4=gui only).  Now with what looks like minor version update,
>> it pulls in the whole Qt framework with everything including qt3support and
>> webkit.
>>
>> Can you elaborate what happened to an utility for capturing short movies
>> from a camera that it started to require webkit, designer, phonon, etc.?
>> Did the author go insane?  Broken prebuild checks?  Can this shit be made
>> optional at least?
> 
> I've just checked on my tindy, it builds fine with my original USE_QT4
> value.

OK, it's my fault, I've committed not paying adequate attention at
additions to my patch. Return me my pointyhat and no cookies at Sunday.
;-)

Rusmir, can you test/approve/commit the following patch? I've just
tested it for building/packaging. The patch restores the staus-quo
for USE_QT4 and allows using the stage phase.


-- 
WBR, Boris Samorodov (bsam)
FreeBSD Committer, http://www.FreeBSD.org The Power To Serve

--------------090105040308010107030601
Content-Type: text/x-diff;
 name="eos-movrec.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="eos-movrec.diff"

Index: /poudriere/ports/default/graphics/eos-movrec/Makefile
===================================================================
--- /poudriere/ports/default/graphics/eos-movrec/Makefile	(revision 328026)
+++ /poudriere/ports/default/graphics/eos-movrec/Makefile	(working copy)
@@ -3,6 +3,7 @@
 
 PORTNAME=	eos-movrec
 DISTVERSION=	0.3.2_beta
+PORTREVISION=	1
 CATEGORIES=	graphics multimedia
 MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/${DISTVERSION}/
 
@@ -16,9 +17,7 @@
 USE_BZIP2=	yes
 USES=		cmake pkgconfig
 USE_DOS2UNIX=	*.pro *.cpp *.h
-USE_QT4=	corelib dbus declarative designer gui help iconengines imageformats \
-		moc_build multimedia network opengl phonon qmake_build qt3support \
-		rcc_build script scripttools sql qt3support uic_build webkit xml xmlpatterns
+USE_QT4=	qmake_build moc_build rcc_build uic_build gui
 
 INSTALLS_ICONS=	yes
 ICON_SIZES=	16x16 32x32 128x128 256x256 512x512
@@ -26,7 +25,6 @@
 DESKTOP_ENTRIES="EOS Camera Movie Recorder" "${COMMENT}" "${PORTNAME}" \
 		"eos_movrec" "Graphics;Photography;Qt;" false
 
-NO_STAGE=	yes
 post-patch:
 	@${REINPLACE_CMD} -e 's|GLIBC|${OPSYS}|' ${WRKSRC}/os_api.h
 .for s in 16 32 128 256 512
@@ -36,10 +34,10 @@
 
 post-install:
 .for s in ${ICON_SIZES}
-	@${MKDIR} ${PREFIX}/share/icons/hicolor/${s}/apps
+	@${MKDIR} ${STAGEDIR}${PREFIX}/share/icons/hicolor/${s}/apps
 	${INSTALL_DATA} ${WRKSRC}/mac.icons/${PORTNAME}_${s}.png \
-		${PREFIX}/share/icons/hicolor/${s}/apps/${PORTNAME}.png
+		${STAGEDIR}${PREFIX}/share/icons/hicolor/${s}/apps/${PORTNAME}.png
 .endfor
-	${LN} -sf ${PREFIX}/share/icons/hicolor/32x32/apps/${PORTNAME}.png ${PREFIX}/share/pixmaps/
+	${LN} -sf ${PREFIX}/share/icons/hicolor/32x32/apps/${PORTNAME}.png ${STAGEDIR}${PREFIX}/share/pixmaps/
 
 .include <bsd.port.mk>

--------------090105040308010107030601--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52414A02.7000900>