Date: Thu, 14 Jul 2005 09:08:58 -0400 (EDT) From: Andrew Gallatin <gallatin@cs.duke.edu> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_xl.c Message-ID: <17110.25578.31335.425537@grasshopper.cs.duke.edu> In-Reply-To: <20050714125145.GA18744@cell.sick.ru> References: <200507131406.j6DE6DLv066313@repoman.freebsd.org> <20050714083608.A21239@grasshopper.cs.duke.edu> <20050714125145.GA18744@cell.sick.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Gleb Smirnoff writes: > On Thu, Jul 14, 2005 at 08:36:08AM -0400, Andrew Gallatin wrote: > A> Gleb Smirnoff [glebius@FreeBSD.org] wrote: > A> > glebius 2005-07-13 14:06:13 UTC > A> > > A> > FreeBSD src repository > A> > > A> > Modified files: > A> > sys/pci if_xl.c > A> > Log: > A> > NET_LOCK_GIANT() when entering network code. > A> > > A> > A> Do other drivers do this? It looks like at least em, fxp > A> and my out-of-tree commercial driver have the same "bug". > > They do. Look at if_ath.c:ath_rx_proc(). This is done in functions > that execute from a separate context - from task queue. > em, fxp and others may not have such functions. Ah, I hadn't realized that xl_rxeof() ran from a task queue. I'm not sure I want to know why it does that ;) Thanks for clearing that up. Drew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?17110.25578.31335.425537>