Date: Mon, 19 Sep 2011 08:40:12 GMT From: Jase Thew <freebsd@beardz.net> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/160820: maintainer update: mail/dovecot2 and dovecot2-pigeonhole Message-ID: <201109190840.p8J8eCmc035583@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/160820; it has been noted by GNATS.
From: Jase Thew <freebsd@beardz.net>
To: bug-followup@FreeBSD.org, bra@fsn.hu
Cc:
Subject: Re: ports/160820: maintainer update: mail/dovecot2 and dovecot2-pigeonhole
Date: Mon, 19 Sep 2011 09:34:37 +0100
This is a multi-part message in MIME format.
--------------060303010801010201060302
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Hi,
The reason for the patch in
dovecot2-pigeonhole/files/patch-doc_Makefile_in hasn't suddenly gone
away with v0.2.4. Without a regenerated version of this patch to apply
to v0.2.4, there will be left-over files :
=== Checking filesystem state
list of extra files and directories in / (not present before this port
was installed but present after it was deinstalled)
3357455 3 drwxr-xr-x 2 root wheel
4 Sep 19 08:08 usr/local/share/doc/dovecot/sieve
3357456 10 -r--r--r-- 1 root wheel
4173 Sep 19 08:08 usr/local/share/doc/dovecot/sieve/vacation.txt
3357457 11 -r--r--r-- 1 root wheel
5016 Sep 19 08:08 usr/local/share/doc/dovecot/sieve/spamtest-virustest.txt
Please refer to ports/158173 for an explanation of why this doc patch is
necessary.
Can you also please keep in mind, just because a patch no longer applies
cleanly, this doesn't mean that the patch (or more specifically, the
issue that it addresses) is no longer relevant.
I strongly recommend that you test future PR patches with either a
tinderbox or ports-mgmt/porttools e.g., so that you can identify issues
such as this (left-over files) and have the opportunity to fix them
before submitting a PR.
I've attached a regenerated
dovecot2-pigeonhole/files/patch-doc_Makefile_in so that the port won't
have any left-over files.
Regards,
Jase.
--
[1] http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/158173#reply4
--------------060303010801010201060302
Content-Type: text/plain;
name="patch-doc_Makefile_in"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename="patch-doc_Makefile_in"
--- doc/Makefile.in.orig 2011-09-17 00:29:32.041186370 +0100
+++ doc/Makefile.in 2011-09-17 00:30:18.168226616 +0100
@@ -210,9 +210,6 @@
top_builddir = @top_builddir@
top_srcdir = @top_srcdir@
SUBDIRS = man example-config
-docfiles = \
- vacation.txt \
- spamtest-virustest.txt
@BUILD_DOCS_TRUE@sieve_doc_DATA = $(docfiles)
EXTRA_DIST = \
@@ -260,7 +257,6 @@
-rm -rf .libs _libs
install-sieve_docDATA: $(sieve_doc_DATA)
@$(NORMAL_INSTALL)
- test -z "$(sieve_docdir)" || $(MKDIR_P) "$(DESTDIR)$(sieve_docdir)"
@list='$(sieve_doc_DATA)'; for p in $$list; do \
if test -f "$$p"; then d=; else d="$(srcdir)/"; fi; \
f=$(am__strip_dir) \
--------------060303010801010201060302--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201109190840.p8J8eCmc035583>