Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 26 Oct 2021 02:37:11 GMT
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 84722e8171a0 - stable/13 - sys_procctl(): zero the data buffer once, on syscall entry
Message-ID:  <202110260237.19Q2bBjY040014@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by kib:

URL: https://cgit.FreeBSD.org/src/commit/?id=84722e8171a0f5732eef9e817573000f93ea9bd8

commit 84722e8171a0f5732eef9e817573000f93ea9bd8
Author:     Konstantin Belousov <kib@FreeBSD.org>
AuthorDate: 2021-10-16 18:28:03 +0000
Commit:     Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2021-10-26 02:26:27 +0000

    sys_procctl(): zero the data buffer once, on syscall entry
    
    (cherry picked from commit 32026f5983ed00e64829f8c20b09748077809729)
---
 sys/kern/kern_procctl.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sys/kern/kern_procctl.c b/sys/kern/kern_procctl.c
index 7a88ef24d987..387706a0cb1e 100644
--- a/sys/kern/kern_procctl.c
+++ b/sys/kern/kern_procctl.c
@@ -171,7 +171,6 @@ reap_status(struct thread *td, struct proc *p, void *data)
 
 	rs = data;
 	sx_assert(&proctree_lock, SX_LOCKED);
-	bzero(rs, sizeof(*rs));
 	if ((p->p_treeflag & P_TREE_REAPER) == 0) {
 		reap = p->p_reaper;
 	} else {
@@ -850,6 +849,8 @@ sys_procctl(struct thread *td, struct procctl_args *uap)
 	if (uap->com == 0 || uap->com >= nitems(procctl_cmds_info))
 		return (EINVAL);
 	cmd_info = &procctl_cmds_info[uap->com];
+	bzero(&x, sizeof(x));
+
 	if (cmd_info->copyin_sz > 0) {
 		error = copyin(uap->data, &x, cmd_info->copyin_sz);
 		if (error != 0)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202110260237.19Q2bBjY040014>