Date: Thu, 14 Jan 2016 10:34:39 +0000 From: Steven Hartland <steven@multiplay.co.uk> To: Andrew Turner <andrew@fubar.geek.nz> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r293903 - in head/sys/boot: arm/uboot efi/fdt efi/libefi Message-ID: <569779BF.6060500@multiplay.co.uk> In-Reply-To: <20160114102456.13921bcf@zapp> References: <201601140922.u0E9M1rV025146@repo.freebsd.org> <20160114101343.70e73d01@zapp> <56977585.4020100@freebsd.org> <20160114102456.13921bcf@zapp>
next in thread | previous in thread | raw e-mail | index | archive | help
On 14/01/2016 10:24, Andrew Turner wrote: > On Thu, 14 Jan 2016 10:16:37 +0000 > Steven Hartland <steven@multiplay.co.uk> wrote: > >> On 14/01/2016 10:13, Andrew Turner wrote: >>> On Thu, 14 Jan 2016 09:22:01 +0000 (UTC) >>> Steven Hartland <smh@FreeBSD.org> wrote: >>> >>>> Author: smh >>>> Date: Thu Jan 14 09:22:01 2016 >>>> New Revision: 293903 >>>> URL: https://svnweb.freebsd.org/changeset/base/293903 >>>> >>>> Log: >>>> Fix GCC warnings causing build failure after r293724 >>>> >>>> Disable some compiler warnings for GCC (non-standard compiler) >>>> fixing build failures introduced by r293724, which enabled WARNS in >>>> the EFI boot code, when compiling with none standard compiler >>>> (GCC). >>>> Raised by: ian >>>> MFC after: 2 weeks >>>> X-MFC-With: r293268 >>>> Sponsored by: Multiplay >>> The attached would be a better (however untested) solution. Given we >>> don't build boot1.efi or loader.efi with gcc it extends this to all >>> the EFI code. >>> >>> Andrew >> Not sure I like that idea as it would prevent people using EFI from >> having a working system if they also choose GCC. >> > They already don't have loader.efi or boot1.efi with gcc, how will this > patch break their existing system? > > Andrew Ahh I see what you mean. I see there's some discussion about this on IRC, if you can reply to this thread and let me know the conclusion, in case I miss it, I'll make the relevant changes :) Regards Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?569779BF.6060500>