Date: Fri, 30 Nov 2001 17:50:41 -0500 From: Andrew Gallatin <gallatin@cs.duke.edu> To: Luigi Rizzo <luigi@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_dc.c if_sis.c Message-ID: <20011130175040.A836@grasshopper.cs.duke.edu> In-Reply-To: <200111292347.fATNllI06694@freefall.freebsd.org>; from luigi@FreeBSD.org on Thu, Nov 29, 2001 at 03:47:47PM -0800 References: <200111292347.fATNllI06694@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Luigi Rizzo [luigi@FreeBSD.org] wrote: > luigi 2001/11/29 15:47:47 PST > > Modified files: > sys/pci if_dc.c if_sis.c > Log: > Per jlemon request, reintroduce some printf() when an > mbuf allocation fails, and fix (i hope) a couple of style bugs. > > I believe these printf() are extremely dangerous because now they can > occur on every incoming packet and are not rate limited. They were > meant to warn the sysadmin about lack of resources, but now they > can become a nice way to panic your system under load. I agree 100%. I've seen messages like this from if_ti swamp a serial console so badly that its faster to reset the machine than to wait for the messages to finish printing.. > Other drivers (e.g. the fxp driver) have nothing like this. Most of the gig drivers have this misfeature too. > There is a pending discussion on putting this kind of warnings > elsewhere, and I hope we can fix this soon. Good.. Some sort of log-scaled limit printf would be good. Drew To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011130175040.A836>