Date: Wed, 18 Dec 2019 11:11:38 +0100 From: Lars Engels <lars.engels@0x20.net> To: Mathieu Arnold <mat@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r520331 - in head/net-mgmt: icingaweb2 icingaweb2-module-businessprocess icingaweb2-module-cube icingaweb2-module-director icingaweb2-module-elasticsearch icingaweb2-module-fileshipper ... Message-ID: <20191218101138.GC41599@e.0x20.net> In-Reply-To: <20191217142156.lkgunsqss4onibwp@atuin.in.mat.cc> References: <201912171343.xBHDhEk9070377@repo.freebsd.org> <20191217142156.lkgunsqss4onibwp@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 17, 2019 at 03:21:56PM +0100, Mathieu Arnold wrote:
> On Tue, Dec 17, 2019 at 01:43:14PM +0000, Lars Engels wrote:
> > +PKGNAMESUFFIX= ${PHP_PKGNAMESUFFIX}
> >
> > +RUN_DEPENDS= icingaweb2-${PHP_FLAVOR}>=2.4.1:net-mgmt/icingaweb2@${PHP_FLAVOR} \
> > + icingaweb2-module-ipl-${PHP_FLAVOR}>=0.1.1:net-mgmt/icingaweb2-module-ipl@${PHP_FLAVOR}
>
> This, and all the other are abusing the fact that PHP_FLAVOR is
> contained in PHP_PKGNAMESUFFIX. The package names in all dependencies
> should be defined with PHP_PKGNAMESUFFIX, NOT PHP_FLAVOR. For example:
>
> icingaweb2${PHP_PKGNAMESUFFIX}>=2.4.1::net-mgmt/icingaweb2@${PHP_FLAVOR}
Thanks! Fluffy@ updated the PR with your suggestion and I committed it.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191218101138.GC41599>