Date: Fri, 4 Aug 2006 11:43:26 -0400 From: John Baldwin <jhb@freebsd.org> To: Paolo Pisati <piso@freebsd.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 103173 for review Message-ID: <200608041143.26838.jhb@freebsd.org> In-Reply-To: <200608041457.k74EvpSw097626@repoman.freebsd.org> References: <200608041457.k74EvpSw097626@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 04 August 2006 10:57, Paolo Pisati wrote: > http://perforce.freebsd.org/chv.cgi?CH=103173 > > Change 103173 by piso@piso_newluxor on 2006/08/04 14:57:30 > > taskqueue_free() executes all the tasks still pending > on that taskqueue: in this case, taskqueue_drain() is > superfluous. > > Affected files ... > > .. //depot/projects/soc2006/intr_filter/dev/bfe/if_bfe.c#6 edit > > Differences ... > > ==== //depot/projects/soc2006/intr_filter/dev/bfe/if_bfe.c#6 (text+ko) ==== > > @@ -475,8 +475,6 @@ > device_delete_child(dev, sc->bfe_miibus); > > bfe_release_resources(sc); > - taskqueue_drain(sc->sc_tq, &sc->sc_stoptask); > - taskqueue_drain(sc->sc_tq, &sc->sc_errorstask); > taskqueue_free(sc->sc_tq); > BFE_UNLOCK(sc); > mtx_destroy(&sc->bfe_mtx); In that case you can't call it while holding the BFE_LOCK. You probably only need the BFE_LOCK around bfe_stop(). -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200608041143.26838.jhb>