Date: Wed, 23 Dec 2020 16:47:21 +0000 From: Brooks Davis <brooks@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: John Baldwin <jhb@freebsd.org>, freebsd-git <freebsd-git@freebsd.org> Subject: Re: Git commit message templates Message-ID: <20201223164721.GA94898@spindle.one-eyed-alien.net> In-Reply-To: <CANCZdfo_CHu83nTJ%2BCT4S_-dKg%2BywtYoxi6RQaARq2FPGeXsWg@mail.gmail.com> References: <CAPyFy2DveYMw6VyxT8QwOCNreHTyi6RoYX1EWEfysMEqCpcjZQ@mail.gmail.com> <c18f71b2-8356-c1ad-b0d7-9b742f2d9fb9@FreeBSD.org> <CAPyFy2CGKgvjmAsFtVwBsuPaR6p6QF5X659fU9VFB%2Bf_N7vosg@mail.gmail.com> <5398f806-42a5-560e-a22c-c5483a0c6f9e@FreeBSD.org> <CANCZdfo_CHu83nTJ%2BCT4S_-dKg%2BywtYoxi6RQaARq2FPGeXsWg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--J2SCkAp4GZ/dPZZf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 21, 2020 at 10:33:48AM -0700, Warner Losh wrote: > On Mon, Dec 21, 2020 at 10:28 AM John Baldwin <jhb@freebsd.org> wrote: >=20 > > On 12/17/20 12:58 PM, Ed Maste wrote: > > > On Wed, 16 Dec 2020 at 17:35, John Baldwin <jhb@freebsd.org> wrote: > > >> > > >> The only one I'm not a fan of is the lack of punctuation for the fir= st > > >> sentence. Newspaper headlines also use additional capitalization > > >> (e.g. last word and "significant words"), so the current recommendat= ion > > >> is a mix of things and not fully consistent with either one. > > > > > > Fair point - considering the first line as one would an email subject > > > is probably the best approach. > > > > I agree. Perhaps just say that (rather than newspaper headline) and le= ave > > off the note about punctuation. > > >=20 > Personally, I think we're starting to get a bit over prescriptive here. > Once you have the length down, and have a keyword at the start, you've got > 99% of the benefit. Nobody cares if there's a dot at the end or not, and > it's presence or absence adds no value to other readers. Nobody cares abo= ut > having lots of caps or not. We should just let people use their judgement. While it makes little difference it seems reasonable to make a suggestion here and for it to follow common conventions. IMO there's little value in un-opinionated style guides. There might be something to be said for flagging things that are more or less important. -- Brooks --J2SCkAp4GZ/dPZZf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJf43SYAAoJEKzQXbSebgfAsqkH/AxLLfFdYGU9/rbVWSvzfAwm 3D+JNKTxEQ4+nHg/UUF4aE6IsR0OrnzztpNW5WLbVEJkEuZ6uEiq+07s42dNS9Q+ rIFKL5X6iagCNbl/ZcIyCHGJy10edP9Incsi5zx/xtDxrWmavWwdYyWtAekmR263 Wvzwtl8Rzbz7ImIqeZ0mUY9wzV0znzn7w1GOL1tCW93cRJ0di1c9wUTq91P2BiKu 4y0NM2+gXKD/J6ioD8+XobU0WyPTcIEKpP+qMRgvg/ZWZg7VdPUrZmhNUKTh0/te yeMgZDQ5cCocedFNZNLNj7rm9rz/UDC8lVOAG8fR3uV67MPOFnjbA2Pk3B/SQFo= =SqPz -----END PGP SIGNATURE----- --J2SCkAp4GZ/dPZZf--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20201223164721.GA94898>