Date: Sat, 3 Mar 2001 00:29:53 -0800 From: Kris Kennaway <kris@obsecurity.org> To: Maxim Sobolev <sobomax@FreeBSD.org> Cc: Kris Kennaway <kris@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/audio/mpg123 Makefile ports/audio/mpg123/files Message-ID: <20010303002953.A66850@mollari.cthul.hu> In-Reply-To: <200103030821.f238Lgf69187@vic.sabbo.net>; from sobomax@FreeBSD.org on Sat, Mar 03, 2001 at 10:21:16AM %2B0200 References: <200103030023.f230NE345500@freefall.freebsd.org> <200103030821.f238Lgf69187@vic.sabbo.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--HcAYCG3uE/tztfnV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 03, 2001 at 10:21:16AM +0200, Maxim Sobolev wrote: > >=20 > > kris 2001/03/02 16:23:13 PST > >=20 > > Modified files: > > audio/mpg123 Makefile=20 > > audio/mpg123/files patch-ab=20 > > Added files: > > audio/mpg123/files patch-ae=20 > > Log: > > Switch the ASM selection code to use CPUTYPE on -current, and hence > > automatically select the correct version without needing to set a > > non-standard environment variable. > > Use random() instead of rand() because I'm sick of getting the same s= ongs > > over and over in shuffle play. > > Quell a format string warning with -Wnon-const-format > > Bump PORTREVISION > > =20 > > Reviewed by: maintainer timeout > ^^^^^^^^^^^^^^^^^^ > It is not true, because: Oops, I didn't notice you had taken over this port from jkoshy. My makefile was out of date when I first tried to commit, and evidently this was before you took over maintainership. > 3. About your CPUTYPE request I replied you that this makes impossible to > use ASM optimisation on anything but very recent -stable and -current. > AFAIK, ports expected to work at least on wide range of systems > between 4.0-RELEASE and pre-CPUTYPE 4-STABLE; Not true -- thats why the OSVERSION tests are there with fallback cases for older systems. I tested the build myself on 4.2-STABLE prior to commit, and it worked as expected. I haven't merged CPUTYPE to -stable yet but will be doing so this weekend. > Therefore I demand that you revert CPUTYPE commit, or I will do it > by myself. Anyway, I'm sorry for stepping on your toes, but I think these features should stay (modulo syntax error fix). However, since you're maintainer, feel free to do what you like. Kris --HcAYCG3uE/tztfnV Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE6oKuAWry0BWjoQKURAqAOAKDV0vnBgnJ/eWq5FdHOwODiNglfUgCg5S4d zrIwRKFWPDGxLdTC3W8WGWY= =fF+u -----END PGP SIGNATURE----- --HcAYCG3uE/tztfnV-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010303002953.A66850>