Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 7 Sep 2011 07:24:46 +0000 (UTC)
From:      Adrian Chadd <adrian@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-user@freebsd.org
Subject:   svn commit: r225432 - user/adrian/if_ath_tx/sys/dev/ath
Message-ID:  <201109070724.p877OkkZ020593@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: adrian
Date: Wed Sep  7 07:24:46 2011
New Revision: 225432
URL: http://svn.freebsd.org/changeset/base/225432

Log:
  Correct the retry bit handling during software TX retransmission.
  
  * only update the bit if retries == 0;
  * if the retry bit is set, resync the descriptor

Modified:
  user/adrian/if_ath_tx/sys/dev/ath/if_ath_tx.c

Modified: user/adrian/if_ath_tx/sys/dev/ath/if_ath_tx.c
==============================================================================
--- user/adrian/if_ath_tx/sys/dev/ath/if_ath_tx.c	Wed Sep  7 03:00:58 2011	(r225431)
+++ user/adrian/if_ath_tx/sys/dev/ath/if_ath_tx.c	Wed Sep  7 07:24:46 2011	(r225432)
@@ -2533,11 +2533,16 @@ ath_tx_set_retry(struct ath_softc *sc, s
 {
 	struct ieee80211_frame *wh;
 
+	wh = mtod(bf->bf_m, struct ieee80211_frame *);
+	/* Only update/resync if needed */
+	if (bf->bf_state.bfs_isretried == 0) {
+		wh->i_fc[1] |= IEEE80211_FC1_RETRY;
+		bus_dmamap_sync(sc->sc_dmat, bf->bf_dmamap,
+		    BUS_DMASYNC_PREWRITE);
+	}
 	sc->sc_stats.ast_tx_swretries++;
 	bf->bf_state.bfs_isretried = 1;
 	bf->bf_state.bfs_retries ++;
-	wh = mtod(bf->bf_m, struct ieee80211_frame *);
-	wh->i_fc[1] |= IEEE80211_FC1_RETRY;
 }
 
 static struct ath_buf *



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201109070724.p877OkkZ020593>