Date: Tue, 24 Sep 2019 15:19:25 -0700 (PDT) From: "Rodney W. Grimes" <freebsd-rwg@gndrsh.dnsmgr.net> To: Eugene Grosbein <eugen@grosbein.net> Cc: Andriy Gapon <avg@freebsd.org>, freebsd-net <freebsd-net@freebsd.org> Subject: Re: dummynet: bandwidth is limited to 2 Gbit/s ? Message-ID: <201909242219.x8OMJP3P013498@gndrsh.dnsmgr.net> In-Reply-To: <5D8A3D35.5050303@grosbein.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 24.09.2019 12:42, Andriy Gapon wrote: > > > It seems that the userland component of ipfw/dummynet uses int for the bandwidth > > represented in bit/s. Also, int is used for passing that value from the > > userland to the kernel. > > > > What would be the best way to extend this? > > Just use a larger type? > > Or maybe add another field to try to preserve KBI backward compatibility? > > > > Thank you. > > AFAIK, we never had any public ABI or stable KBI interface announced to userland or in-kernel consumers > and had no consumers of dummynet other than ipfw(8) binary. Just increase type. Any attempt to mfc this would break KABI/userland and that is never a good thing to do. It may not be a public ABI, but it is an ABI, and stability of that and backwards compatibility are always a good thing to strive for. -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201909242219.x8OMJP3P013498>