Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 10 May 2001 19:04:45 +1000 (EST)
From:      Bruce Evans <bde@zeta.org.au>
To:        Warner Losh <imp@harmony.village.org>
Cc:        Dima Dorfman <dima@unixfreak.org>, audit@FreeBSD.ORG
Subject:   Re: jot(1) patch 
Message-ID:  <Pine.BSF.4.21.0105101858240.1351-100000@besplex.bde.org>
In-Reply-To: <200105092127.f49LR7b40095@harmony.village.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 9 May 2001, Warner Losh wrote:

> In message <20010509210433.1BDA13E28@bazooka.unixfreak.org> Dima Dorfman writes:
> : 	- use getopt
> : 	- de-register
> 
> You should de __P() as well.  The changes add a prototype
> 
> : -usage()
> : +usage(void)
> 
> which breaks K&R compatibility.  So do one or the other.  The one
> thing worse than old K&R code in the tree is broken K&R code in the
> tree.

You should just not gratuitously break usage().  usage() is already
declared to take a void in its forward declaration using __P(()),
so using "void" in its definition just breaks K&R support.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0105101858240.1351-100000>