Date: Tue, 16 Apr 2002 10:52:16 +0300 From: Maxim Sobolev <sobomax@FreeBSD.org> To: Joe Marcus Clarke <marcus@marcuscom.com> Cc: Arne H Juul <Arne.Juul@fast.no>, gnome@FreeBSD.ORG Subject: Re: gnomemedia patches Message-ID: <3CBBD830.FAF5A56A@FreeBSD.org> References: <Pine.BSF.4.10.10204160131160.65059-100000@midten.fast.no> <1018925720.302.16.camel@gyros.marcuscom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Joe Marcus Clarke wrote: > > On Mon, 2002-04-15 at 20:49, Arne H Juul wrote: > > To get the Gnome CD player application (gtcd) to > > play nicely on my FreeBSD 4.5 system and send > > updates to freedb.org I had to make a couple of patches > > to gnome-media-1.2.3. > > > > The first i'm not completely sure of - it tried to access > > /usr/X11R6/share/gnome/gnome/cddb-submit-methods instead > > of /usr/X11R6/share/gnome/cddb-submit-methods but of course > > the fix may be in the wrong place; I think it's needed > > only because of the existing FreeBSD patches/configure > > machinery that forces $(datadir) to /usr/X11R6/share/gnome > > while the gnome files want to use $(datadir)/gnome instead. > > So the "right" fix may be to configure with --datadir > > /usr/X11R6/share and revert these FreeBSD specific patches > > for all I know. > > This looks good to me. > > > > > The second fix (make sure we have the device open to do the ioctl) > > is copied from the similar linux case so I'm pretty sure it's right > > (or at least, better than the previous version) so it doesn't read > > the volume as 0 all the time. > > This also seems reasonable. Maxim, what do you think? Patches are fine to me. Please commit them and don't forget to bump PORTREVISION. Thanks! -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-gnome" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3CBBD830.FAF5A56A>