Date: Wed, 22 Oct 1997 17:18:27 +1000 From: Bruce Evans <bde@zeta.org.au> To: current@FreeBSD.ORG, roberto@keltia.freenix.fr Subject: Re: nullfs & current UPDATE! Message-ID: <199710220718.RAA03072@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>I tried to be consistent with the code around in null_vnops.c... Do you >think we should change both miscfs/nullfs and miscfs/umapfs to conform to >style(9) ? The code has been like this since 4.4BSD-lite... No, don't change old code. Just write perfect new code :-). >> temporary variables. `lowervp' can be written fairly concisely as >> VTONULL(ap->a_vp)->null_lowervp. In fact, there is already a macro >> NULLVPTOLOWERVP() for this. It seems to be used consistently to set >> `lowervp' variables that are passed to other functions and not used again, >> as lowervp is here. > >It is not used consistly in nullfs :-( It was in the Lite2 version :-). All cases except one where xp->null_lowervp is used already had xp handy. The one exception was a FreeBSD addition in null_vfsops.c:nullfs_mount(). Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199710220718.RAA03072>