Date: Tue, 11 Jun 2013 23:52:13 +0200 From: Eitan Adler <eadler@freebsd.org> To: Baptiste Daroussin <bapt@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r320546 - in head/devel: . tradcpp tradcpp/files Message-ID: <CAF6rxgktP=ORcmTREbdx2yUUjrmHXZVtnbRyjJ5T2nWMty_vrA@mail.gmail.com> In-Reply-To: <20130611170026.GE35160@ithaqua.etoilebsd.net> References: <201306111055.r5BAtHmb094470@svn.freebsd.org> <CAF6rxg=iqSGrFK3Ug0Hzh6nRGnzUA5-Ug_aXrGs4xybBPAty3A@mail.gmail.com> <20130611164037.GD35160@ithaqua.etoilebsd.net> <CAF6rxgnt%2BvpD_zFVbe5GwcwZB5_gsB67SkwN5_2Xw7dPkkNVJw@mail.gmail.com> <20130611170026.GE35160@ithaqua.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jun 11, 2013 at 7:00 PM, Baptiste Daroussin <bapt@freebsd.org> wrote: > On Tue, Jun 11, 2013 at 06:48:34PM +0200, Eitan Adler wrote: >> On Tue, Jun 11, 2013 at 6:40 PM, Baptiste Daroussin <bapt@freebsd.org> wrote: >> > No patching is better, has I'm heavily working with upstream on this port. >> > >> > In general disable warning is something I don't like, I prefer to fix them, and >> > I don't find that complexify the port at all. >> >> I've found patching software often leads to introducing subtle bugs: >> its incredibly annoying trying to track down a bug only to determine >> that is is a distro patch. Also, it makes it more difficult for the >> reader of the patch to figure out why the patch is there: >> it increases the mental effort before "oh, maintainer is just working >> around compiler warnings" >> >> That said, this isn't a strong feeling. > > I know exactly what I'm doing and why, I know why I do patch, and I'm working as > said in the previous mail directly with upstream (those patches are now > integrated in better vesions). > > I think I have enough experience in the ports tree to decide if I should patch > or not my own ports. Whoa! Understood. I hope I did not offend you with my questions. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgktP=ORcmTREbdx2yUUjrmHXZVtnbRyjJ5T2nWMty_vrA>