Date: Sat, 15 Apr 2017 09:24:51 -0700 From: Mark Johnston <markj@freebsd.org> To: rgrimes@freebsd.org Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r316938 - head/sbin/savecore Message-ID: <20170415162437.GA89653@raichu> In-Reply-To: <201704150642.v3F6g41p010449@pdx.rh.CN85.dnsmgr.net> References: <20170415053729.GA76139@raichu> <201704150642.v3F6g41p010449@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 14, 2017 at 11:42:04PM -0700, Rodney W. Grimes wrote: > > On Fri, Apr 14, 2017 at 06:30:17PM -0700, Rodney W. Grimes wrote: > > > > The patch to add compression support is here and should largely still > > > > work: > > > > https://people.freebsd.org/~markj/patches/core-compression/20141110-kern_dump.diff > > > > > > > > I've been hesitant about pushing it forward: > > > > - The dump_write* APIs need some simplification after the addition of > > > > encrypted dump support and support for dumping to 4Kn drives. > > > > - I'm not sure how encryption should compose with compression. It seems > > > > intuitively obvious that we should compress before encrypting if the > > > > compression is to be of any use, but I don't know enough to know > > > > whether the compression might somehow compromise the effectiveness of > > > > the encryption. > > > > > > > > If anyone has some insight on the second of these two points, I'd > > > > appreciate hearing it. > > > > > > I have a large amount of reworking and modulization of the dump code > > > incuding intergration of your (markj) compressed dumps. Layer isnt > > > implemented but is in the plan. I should not of held off on the net > > > dump code as it got smashed by encrypted dumps, then again by > > > the libif'ing for all the Intel drives that had been netdump modified. > > > > > > Basically now starting over :-( > > > > Could you post your patches somewhere? I've been sitting on this (and > > the netdump patches, for which I have quite a few modifications) for far > > too long, and would like to finish them and get them in soon. I'll note > > that the netdump code posted a few years ago had some problems that are > > fixed in Isilon's version, which I'm working on rebasing on HEAD. In > > Isnt the code I rebaed in December to -12 your code from Isiolon???? I don't know exactly what code you're referring to. > Or tell me you handed me your patches to upstream, and then continued > to evolved the code without letting me know? Are YOUR patckes some > place public? I dont think mine are, but I do have a link in > http://people.freebsd.org/~rgrimes pointing to the other Netdump version > that I think is an old version of your code. I haven't changed the compression patch since I posted it a long time ago: https://people.freebsd.org/~markj/patches/core-compression/20141110-kern_dump.diff I've made a fairly large set of changes to the netdump code linked on your page. Some of the changes were motivated by the objections raised to the original set of patches. I currently don't have a working copy of my netdump patches against HEAD, but here are some internal patches: https://people.freebsd.org/~markj/patches/netdump/ A recent revision of the netdumpd code is here: https://github.com/markjdb/netdumpd
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170415162437.GA89653>