Date: Wed, 23 Aug 1995 21:49:33 +0800 (WST) From: Peter Wemm <peter@haywire.DIALix.COM> To: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com> Cc: CVS-commiters@freefall.FreeBSD.org, cvs-CVSROOT@freefall.FreeBSD.org Subject: Re: cvs commit: CVSROOT cvsedit Message-ID: <Pine.SV4.3.91.950823213505.29188H-100000@haywire.DIALix.COM> In-Reply-To: <199508231311.GAA09339@gndrsh.aac.dev.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 23 Aug 1995, Rodney W. Grimes wrote: > > peter 95/08/23 04:42:35 > > > > Modified: . cvsedit > > Log: > > Fix incorrect Regexp that zapped Satoshi's Submitted-by line.. :-( > > This got past both Rod and I.. :-( > > :-(. I guess we better get a third set of eyes to look things over from > here on out. Can I have an ``expert'' class perl hacker get in contact > with me for just such reviews? > > Peter has several more changes (and so do I) to the perl scripts used to > smarten up cvs, and it looks like we better send them out to a third > set of eyes looking for this type of stuff. Also, about the lack of review on this change.. This was an incredibly obvious fix once the existance of the problem was known.. :-( It was pretty important to get it in ASAP, and when (apparently) nobody was around to bounce it off, I dived in. I have a suggestion for this sort of thing in the future.. When *initiating* changes to the CVSROOT perl scripts, how about we email the diff to cvs-commmitters first, and let it stew for 24 hours. It'd be much more likely that some of the 60 or so pairs of eyes would pick up this sort of editing slip. It's the perl "literate, but non-guru" types who would most likely pick up the logic problems, as they would not be quite as distracted by the construction of the expressions. -Peter
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.SV4.3.91.950823213505.29188H-100000>