Date: Mon, 18 May 1998 14:24:12 -0700 (PDT) From: Julian Elischer <julian@whistle.com> To: Bruce Evans <bde@zeta.org.au> Cc: guido@FreeBSD.ORG, jhay@mikom.csir.co.za, cvs-committers@FreeBSD.ORG Subject: Re: cvs commit: src/sys/netinet tcp_input.c Message-ID: <Pine.BSF.3.95.980518142310.18931I-100000@current1.whistle.com> In-Reply-To: <199805182054.GAA30065@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 19 May 1998, Bruce Evans wrote: > >> guido 1998/05/18 10:07:59 PDT > >> > >> Modified files: > >> sys/netinet tcp_input.c > >> Log: > >> Add some parenthesis for clarity and fix a bug > >> Pointed out by: Garrett Wollmand > > ^ > >Shouldn't you also add this to rc.network so that it can start > >automatically on new machines? :-) > > Then you should also add the bd :-). It deletes parentheses for > clarity. Its review of this patch: "2 extra layers of parentheses > is 2 more layers than I would use and 1 more layer than KNF. This > change has no affect on the object code. Where is the bug fix?". > > [The change was from `(foo & BAR && ...' to (((foo & BAR) != 0) && ...'.] there may not have been a bug but it's a hell of a lot easier to read.. > > Bruce > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.95.980518142310.18931I-100000>